Copilot commented on code in PR #6700: URL: https://github.com/apache/incubator-kie-drools/pull/6700#discussion_r3207904831
########## drools-mvel/src/main/java/org/drools/mvel/java/JavaForMvelDialectConfiguration.java: ########## @@ -35,9 +35,9 @@ * The valid values are "ECLIPSE" and "NATIVE" only. * * drools.dialect.java.compiler = <ECLIPSE|NATIVE> - * drools.dialect.java.compiler.lnglevel = <1.5|1.6> - * - * The default compiler is Eclipse and the default lngLevel is 1.5. + * drools.dialect.java.compiler.lnglevel = <17|18|19|20|21> + * + * The default compiler is Eclipse and the default lngLevel is 17. * The lngLevel will attempt to autodiscover your system using the Review Comment: This class-level Javadoc claims the default compiler is Eclipse and default language level is 17, but `JavaForMvelDialectConfiguration()` (and its superclasses) don’t set those defaults unless `init(...)` is called. Either initialize defaults in constructors or clarify in the Javadoc that defaults are established during `init(...)`/builder configuration, not by the default constructor. ########## kie-memory-compiler/src/main/java/org/kie/memorycompiler/JavaConfiguration.java: ########## @@ -31,7 +31,7 @@ * The valid values are "ECLIPSE" and "NATIVE" only. * * drools.dialect.java.compiler = <ECLIPSE|NATIVE> - * drools.dialect.java.compiler.lnglevel = <1.5|...|21> + * drools.dialect.java.compiler.lnglevel = <17|18|19|20|21> * * The default compiler is Eclipse and the default lngLevel is 17. * The lngLevel will attempt to autodiscover your system using the Review Comment: The Javadoc states that the default compiler is Eclipse and the default language level is 17, but `JavaConfiguration` itself doesn’t initialize `compiler` or `languageLevel` (both are `null` until set). Consider either initializing these fields (e.g., in a constructor) or adjusting the Javadoc to clarify that defaults are applied by callers (e.g., `JavaDialectConfiguration.init(...)` / `findJavaVersion()`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
