ch-lukas opened a new pull request, #3569:
URL: https://github.com/apache/incubator-kie-tools/pull/3569

   Closes : 
[kie-issues#2305](https://github.com/apache/incubator-kie-issues/issues/2305)
   
   The Kubernetes Dev Deployments code path issued browser→runtime fetches
   directly, bypassing the configured cors-proxy. Because the
   dev-deployment runtime image does not configure CORS headers for
   cross-origin requests, the browser blocked these calls and the
   deployment row stayed in an error state even when the pod was Ready.
   
   Brings the Kubernetes path to parity with the OpenShift path, which
   already routes through the cors-proxy via the existing `target-url`
   header convention (also used by `kubernetes-bridge`'s `ResourceFetcher`).
   
   **Changes**
   
   - `KieSandboxDevDeploymentsService.getHealthStatus` and the upload-status
     / upload calls in `KieSandboxDevDeploymentsUploadAppApi` now route
     through `proxyUrl` via the `target-url` header when one is configured.
   - `KieSandboxKubernetesService` is instantiated in
     `DevDeploymentsContextProvider` with `proxyUrl: 
env.KIE_SANDBOX_CORS_PROXY_URL`,
     matching how the OpenShift service is constructed.
   - `KubernetesService.getBaseUrl` preserves the `connection.host`
     pathname when proxying, fixing K8s API URLs that include a path
     prefix (e.g. kind's `localhost/kube-apiserver`).
   
   **Test plan**
   
   - [x] Manual: deploy a model from KIE Sandbox against a kind cluster
     whose runtime image lacks CORS headers; verify `/q/health` succeeds
     via DevTools → Network and the dropdown shows the deployment as Up.
   - [x] Verified the OpenShift code path is structurally unchanged (the
     diff in `KieSandboxOpenShiftService` is empty).
   - [ ] CI: TypeScript, ESLint, Jest, Playwright on Linux.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to