nrknithin commented on code in PR #2331:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2331#discussion_r3239512480
##########
data-audit/kogito-addons-data-audit-springboot/src/main/java/org/kie/kogito/app/audit/springboot/SpringbootAuditDataConfiguration.java:
##########
@@ -21,19 +21,37 @@
import org.springframework.beans.factory.config.BeanPostProcessor;
import org.springframework.boot.SpringBootConfiguration;
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
+import
org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.ComponentScan;
+import org.springframework.http.converter.json.Jackson2ObjectMapperBuilder;
+import
org.springframework.http.converter.json.MappingJackson2HttpMessageConverter;
import org.springframework.orm.jpa.LocalContainerEntityManagerFactoryBean;
+import com.fasterxml.jackson.databind.ObjectMapper;
+
@SpringBootConfiguration
@EnableAutoConfiguration
@ComponentScan
public class SpringbootAuditDataConfiguration {
- // Hibernate 7 + Spring ORM 6.2 workaround: Hibernate 7's
SessionFactory.getSchemaManager()
- // returns org.hibernate.relational.SchemaManager, conflicting with JPA
3.2's
- // EntityManagerFactory.getSchemaManager() returning
jakarta.persistence.SchemaManager.
- // Force plain JPA interface to avoid JDK Proxy incompatible return type
error.
+ // TODO Jackson 3 migration: drop this Jackson 2 @Bean when the data-audit
addon moves to Jackson 3.
Review Comment:
@yesamer Done, link to the tracking issue
[drools#6702](https://github.com/apache/incubator-kie-drools/issues/6702) added
##########
data-index/data-index-springboot/data-index-storage-jpa-springboot/src/test/java/org/kie/kogito/index/jpa/springboot/KogitoSpringBootApplication.java:
##########
@@ -20,11 +20,21 @@
import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;
+import org.springframework.context.annotation.Bean;
+import org.springframework.http.converter.json.Jackson2ObjectMapperBuilder;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
@SpringBootApplication(scanBasePackages = { "org.kie.kogito.**" })
public class KogitoSpringBootApplication {
public static void main(String[] args) {
SpringApplication.run(KogitoSpringBootApplication.class, args);
}
+
+ // TODO Jackson 3 migration: drop this Jackson 2 @Bean when the data-index
Spring side moves to Jackson 3.
+ @Bean
Review Comment:
@yesamer Done, link to the tracking issue
[drools#6702](https://github.com/apache/incubator-kie-drools/issues/6702) added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
