yesamer commented on code in PR #6686:
URL: 
https://github.com/apache/incubator-kie-drools/pull/6686#discussion_r3240082843


##########
drools-traits/src/main/java/org/drools/traits/core/factmodel/AbstractTraitFactory.java:
##########
@@ -194,6 +198,10 @@ protected static String getKey(Class core, Class trait) {
     }
 
     protected Class<T> buildProxyClass(K core, Class<?> trait) {
+        // The trait class builder factory is static and may have been left in 
a different
+        // VirtualPropertyMode by an earlier call. Re-sync it to this 
factory's mode so the
+        // generated proxy class has constructors that match the lookup in 
cacheConstructor.
+        syncBuilderFactoryWithMode(mode);
 

Review Comment:
   @nrknithin I don't know that module, but it looks weird that a SB update 
impacts it. I mean, that should be a framework agnostic module.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to