mdproctor opened a new issue, #6721: URL: https://github.com/apache/incubator-kie-drools/issues/6721
Three minor items found during code review of #6718 (RuleBody descriptor redesign). None affect correctness for current tests. ## 1. Code duplication: subscribeWithFilter / subscribeWithFilters `BruteForceCompiledEngine` and `ReteEngine` each have their own copy of `subscribeWithFilter()` and `subscribeWithFilters()`. Extract to a shared package-private utility (`BetaProcessorWiring` or similar). ## 2. Right-side multi-filter asymmetry in 2-pattern path `BruteForceCompiledEngine.wireHead()` 2-pattern path uses `findAlphaFilterPredicate()` (returns only the *first* alpha constraint) for the right-side inlet. If a Pattern has multiple arity-1 LambdaConstraints, only the first applies to the right inlet. Left side uses `subscribeWithFilters()` (applies all). Fix to use `subscribeWithFilters()` consistently for both sides. ## 3. Pre-existing: `RuleUnitChangeSet.remove()` calls `removed.remove(rule)` instead of `removed.add(rule)` `RuleBaseModifier.java` line ~157: `removed.remove(rule)` should be `removed.add(rule)` for the remove-tracking Set to work correctly. Pre-existing before #6718 but noted during review. Refs #6718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
