gitgabrio commented on code in PR #6748:
URL: 
https://github.com/apache/incubator-kie-drools/pull/6748#discussion_r3373418142


##########
kie-parent/pom.xml:
##########
@@ -296,6 +295,7 @@
     <version.org.w3c.dom>2.3.0-jaxb-1.0.6</version.org.w3c.dom>
     <version.org.webjars.bootstrap>5.1.3</version.org.webjars.bootstrap>
     <version.org.webjars.jquery>3.6.0</version.org.webjars.jquery>
+    <version.org.eclipse.jetty>12.0.33</version.org.eclipse.jetty>

Review Comment:
   hi @ChinchuAjith 
   Could you please preserve the alphabetic order of both `properties` and 
`dependency declarations` ? THanks!
   



##########
kie-parent/pom.xml:
##########
@@ -329,6 +329,14 @@
   </properties>
   <dependencyManagement>
     <dependencies>
+      <!-- Import Jetty BOM to ensure consistent Jetty 12.0.33 versions -->

Review Comment:
   hi @ChinchuAjith
   Could you please preserve the alphabetic order of both properties and 
dependency declarations ? THanks!



##########
kie-parent/pom.xml:
##########
@@ -1596,6 +1604,47 @@
         <artifactId>jetty-jakarta-servlet-api</artifactId>
         <version>${version.org.eclipse.jetty.jakarta.servlet.api}</version>
       </dependency>
+      <!-- Explicit Jetty 12.0.33 dependency management to prevent version 
conflicts -->

Review Comment:
   hi @ChinchuAjith
   Could you please preserve the alphabetic order of both properties and 
dependency declarations ? THanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to