ljmotta commented on code in PR #3624:
URL:
https://github.com/apache/incubator-kie-tools/pull/3624#discussion_r3402277828
##########
packages/bpmn-editor/tests-e2e/flowElements/addSubProcess.spec.ts:
##########
@@ -253,9 +254,68 @@ test.describe("Add node - Sub-process", () => {
await expect(nodes.get({ name: "Order Processing" })).toBeAttached();
- const subProcess = await jsonModel.getFlowElement({ elementIndex: 0 });
+ const subProcess = (await jsonModel.getSubProcesses())[0];
+ expect(subProcess?.__$$element).toBe("subProcess");
+ expect(subProcess?.["@_name"]).toBe("Order Processing");
+ });
+ });
+
+ test.describe("Sub-process default properties", () => {
+ test(`should check sub-process default properties`, async ({ palette,
nodes, jsonModel }) => {
+ await palette.dragNewNode({ type: NodeType.SUB_PROCESS, targetPosition:
{ x: 100, y: 300 } });
+ await expect(nodes.get({ name: DefaultNodeName.SUB_PROCESS
})).toBeAttached();
+
+ const subProcess = (await jsonModel.getSubProcesses())[0];
+ expect(subProcess.__$$element).toBe("subProcess");
+ expect(subProcess["@_name"]).toBe(DefaultNodeName.SUB_PROCESS);
+ expect(subProcess["@_triggeredByEvent"]).toBe(false);
+
expect(subProcess.extensionElements?.["drools:metaData"]?.length).toBe(1);
+
expect(subProcess.extensionElements?.["drools:metaData"]?.[0]["@_name"]).toBe("customAsync");
+ });
+
+ test(`should check event sub-process default properties`, async ({
palette, nodes, jsonModel }) => {
+ await palette.dragNewNode({ type: NodeType.SUB_PROCESS, targetPosition:
{ x: 100, y: 300 } });
+ await nodes.morph({ node: nodes.get({ name: DefaultNodeName.SUB_PROCESS
}), to: SubProcessNodeType.EVENT });
+ await expect(nodes.get({ name: DefaultNodeName.SUB_PROCESS
})).toBeAttached();
+
+ const subProcess = (await jsonModel.getSubProcesses())[0];
expect(subProcess.__$$element).toBe("subProcess");
- expect(subProcess["@_name"]).toBe("Order Processing");
+ expect(subProcess["@_name"]).toBe(DefaultNodeName.SUB_PROCESS);
+ expect(subProcess["@_triggeredByEvent"]).toBe(true);
+
expect(subProcess.extensionElements?.["drools:metaData"]?.length).toBe(1);
+
expect(subProcess.extensionElements?.["drools:metaData"]?.[0]["@_name"]).toBe("customAsync");
Review Comment:
Good catch! I'll add the property check!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
