This is an automated email from the ASF dual-hosted git repository.
Rikkola pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-kie-drools.git
The following commit(s) were added to refs/heads/main by this push:
new 3b5010c994 fix(drools-core): guard subnetwork-not right-delete against
null memory (#6756)
3b5010c994 is described below
commit 3b5010c99441ac642f93b1d97dcfd2b2952dd29a
Author: Toni Rikkola <[email protected]>
AuthorDate: Mon Jun 15 10:18:18 2026 +0300
fix(drools-core): guard subnetwork-not right-delete against null memory
(#6756)
PhreakSubnetworkNotExistsNode.deleteRight removed each delete-staged right
tuple from its memory unconditionally. A subnetwork right tuple whose insert
was staged then unstaged in the same cycle never enters a memory list, so
rightTuple.getMemory() is null and the remove NPEs:
java.lang.NullPointerException: Cannot invoke "TupleList.remove(...)"
because the return value of "TupleImpl.getMemory()" is null
at
PhreakSubnetworkNotExistsNode.deleteRight(PhreakSubnetworkNotExistsNode.java:92)
Guard the removal exactly as the sibling beta nodes already do —
PhreakNotNode,
PhreakExistsNode, PhreakJoinNode and PhreakAccumulateNode all skip the
remove
when getMemory() is null ("it may have been staged and never actually
added").
This node was the lone right-delete path missing that guard.
Reproduces on mainline with plain PatternDSL — two subnetwork nots in STREAM
mode, no sequencing involved. Adds SubnetworkNotDeleteRightNpeTest.
Fixes apache/incubator-kie-issues#2338
Co-authored-by: Claude Opus 4.8 <[email protected]>
---
.../core/phreak/PhreakSubnetworkNotExistsNode.java | 7 +-
.../SubnetworkNotDeleteRightNpeTest.java | 86 ++++++++++++++++++++++
2 files changed, 92 insertions(+), 1 deletion(-)
diff --git
a/drools-core/src/main/java/org/drools/core/phreak/PhreakSubnetworkNotExistsNode.java
b/drools-core/src/main/java/org/drools/core/phreak/PhreakSubnetworkNotExistsNode.java
index 2bfebc03ac..3425821358 100644
---
a/drools-core/src/main/java/org/drools/core/phreak/PhreakSubnetworkNotExistsNode.java
+++
b/drools-core/src/main/java/org/drools/core/phreak/PhreakSubnetworkNotExistsNode.java
@@ -89,7 +89,12 @@ public class PhreakSubnetworkNotExistsNode {
TupleImpl leftTuple = node.getStartTuple(rightTuple);
// don't use matches here, as it may be null, if the LT was
also being removed.
- rightTuple.getMemory().remove(rightTuple);
+ // memory can likewise be null: the right tuple may have been
staged then unstaged in
+ // the same cycle, never actually added to a memory list.
+ TupleList rightMemory = rightTuple.getMemory();
+ if (rightMemory != null) {
+ rightMemory.remove(rightTuple);
+ }
TupleList matches = (TupleList) leftTuple.getContextObject();
if (matches != null && matches.isEmpty()) { // matches is
null, if LT was deleted too
diff --git
a/drools-model/drools-model-compiler/src/test/java/org/drools/modelcompiler/SubnetworkNotDeleteRightNpeTest.java
b/drools-model/drools-model-compiler/src/test/java/org/drools/modelcompiler/SubnetworkNotDeleteRightNpeTest.java
new file mode 100644
index 0000000000..237994c408
--- /dev/null
+++
b/drools-model/drools-model-compiler/src/test/java/org/drools/modelcompiler/SubnetworkNotDeleteRightNpeTest.java
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.drools.modelcompiler;
+
+import org.drools.model.Rule;
+import org.drools.model.Variable;
+import org.drools.model.impl.ModelImpl;
+import org.junit.jupiter.api.Test;
+import org.kie.api.KieBase;
+import org.kie.api.KieServices;
+import org.kie.api.conf.EventProcessingOption;
+import org.kie.api.definition.type.Role;
+import org.kie.api.runtime.KieSession;
+
+import static org.assertj.core.api.Assertions.assertThatCode;
+import static org.drools.model.DSL.and;
+import static org.drools.model.DSL.declarationOf;
+import static org.drools.model.DSL.execute;
+import static org.drools.model.DSL.not;
+import static org.drools.model.PatternDSL.pattern;
+import static org.drools.model.PatternDSL.rule;
+
+public class SubnetworkNotDeleteRightNpeTest {
+
+ @Role(Role.Type.EVENT)
+ public static class EventA { private final int id; public EventA(int id) {
this.id = id; } public int getId() { return id; } }
+ @Role(Role.Type.EVENT)
+ public static class EventB { private final int id; public EventB(int id) {
this.id = id; } public int getId() { return id; } }
+
+ private int exprSeq = 0;
+
+ @Test
+ public void twoSubnetworkNots_separatedByPlainNot_doesNotNpeOnDelete() {
+ Variable<EventA> eventA1 = declarationOf(EventA.class), eventA2 =
declarationOf(EventA.class);
+ Variable<EventB> eventB1 = declarationOf(EventB.class), eventB2 =
declarationOf(EventB.class);
+
+ Rule rule = rule("twoSubnetworkNots").build(
+ not(and(anyOf(eventA1), anyOf(eventB1))), // subnetwork not
+ not(and(anyOf(eventA2), anyOf(eventB2))), // subnetwork not
+ execute(() -> { }));
+
+ KieBase kieBase = KieBaseBuilder.createKieBaseFromModel(
+ new ModelImpl().addRule(rule),
+ EventProcessingOption.STREAM
+ );
+
+ KieSession ksession = kieBase.newKieSession(
+ KieServices.get().newKieSessionConfiguration(),
+ null);
+
+ Object[] objects= {
+ new EventA(0),
+ new EventB(1)
+ };
+
+ assertThatCode(() -> {
+ for (Object object : objects) {
+ ksession.insert(object);
+ ksession.fireAllRules();
+ }
+ ksession.fireAllRules();
+ }).doesNotThrowAnyException();
+
+ ksession.dispose();
+ }
+
+ private <T> org.drools.model.PatternDSL.PatternDef<T> anyOf(Variable<T>
event) {
+ return pattern(event).expr("any_" + (exprSeq++), x -> true);
+ }
+}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
