Re: [PR] kie-issues#2356: BPMN Editor: Subprocess with an Error Start Event causes BPMN code generation to fail [incubator-kie-tools]

[via GitHub]

SUNILathulya commented on PR #3640:
URL: 
https://github.com/apache/incubator-kie-tools/pull/3640#issuecomment-4889121603

   > Thank you for the changes.
   > 
   > ### Manual review
   > I created a diagram using this PR. I was able to define error start event
   > 
   > <img alt="Image" width="638" height="409" 
src="https://private-user-images.githubusercontent.com/8044780/616722801-f159eea5-94c8-4570-928a-c6e3f515eadd.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODMwNjU4OTUsIm5iZiI6MTc4MzA2NTU5NSwicGF0aCI6Ii84MDQ0NzgwLzYxNjcyMjgwMS1mMTU5ZWVhNS05NGM4LTQ1NzAtOTI4YS1jNmUzZjUxNWVhZGQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDcwMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjA3MDNUMDc1OTU1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YmYyZDExNWM0Zjg4MTMyN2MwNGVjOTEzNDZmOTNiMDFiMzhlOTAwOWY3YzEzOWU0NjVjYThjMzQxMTgzZWNiMSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmcmVzcG9uc2UtY29udGVudC10eXBlPWltYWdlJTJGcG5nIn0.uqGdEfVD2tiy4WJf8rffsWbNDPXkdKKi7IAJN6xEI5g";>
   > but once I move the start event it is reset to a default one
   > 
   > <img alt="Image" width="581" height="363" 
src="https://private-user-images.githubusercontent.com/8044780/616722642-487a8e32-8b72-4433-a19c-12c03978bd2e.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODMwNjU4OTUsIm5iZiI6MTc4MzA2NTU5NSwicGF0aCI6Ii84MDQ0NzgwLzYxNjcyMjY0Mi00ODdhOGUzMi04YjcyLTQ0MzMtYTE5Yy0xMmMwMzk3OGJkMmUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDcwMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjA3MDNUMDc1OTU1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MTQ5MzMzYjA5Nzc4ZWEzM2ZlNmE2MjM5YjAyOTAxN2UxMTc0MDJhODU0NzM2NTMyNjZmZmY5NzA1NmFmZTYxNSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmcmVzcG9uc2UtY29udGVudC10eXBlPWltYWdlJTJGcG5nIn0.eHfnCmSBdn8ZSupR233OdinKydF7mngpSR4p9uynGxc";>
   > ### Code review
   > To stay consistent in PRs, I think we should add tests. Same requirement 
for tests is common also in other PRs, see [#3635 
(review)](https://github.com/apache/incubator-kie-tools/pull/3635#pullrequestreview-4619086949)
   
   Thank You for your review, will check this issue and add required test cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org