tkobayas commented on PR #4594:
URL: 
https://github.com/apache/incubator-kie-docs/pull/4594#issuecomment-4910987130

   @drccrd In `ExtendsTest.testGeneratedMethods` and `ExtendsTest.testDeepExt`, 
`@position` is used in declared types, not Java classes.
   
   Rather, `DeclaredTypesTest.testExtendPojoInheritedFieldsConstructor` (which 
you wrote) is the test case with `@Position` on `PositionalParent`. Indeed the 
test passes with non-exec-model and exec-model. However, if I add `@Position(2) 
private long salary;` to `PositionalParent` and change the constructor in the 
DRL to `new Child("Mario", 40, 50l,"Sales")`, non-exec-model failed while 
exec-model succeeded. Please try. (if not fail, add more fields)
   
   So I'd say non-exec-model constructor arg order is non-deterministic, not 
respecting `@Position`. `ClassDefinitionFactory.populateDefinitionFromClass` 
seems to handle `@Position`, but is not actually effective in the end. You may 
raise a PR if you want to fix. (We are not eagerly fix issues in non-exec-model 
as it's deprecated)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to