jomarko commented on PR #3652: URL: https://github.com/apache/incubator-kie-tools/pull/3652#issuecomment-4955611620
Thank you for a detailed comment @ch-lukas . I think I now understand properly the changes. ### Before <img width="549" height="102" alt="Screenshot 2026-07-13 092616" src="https://github.com/user-attachments/assets/803fbd48-530d-4813-a53b-ddeded98d7af"; /> If user set the source magnet point to the green one, then moving the source node had no effect to the magnet point. Always the green one was in use. ### Now <img width="557" height="103" alt="Screenshot 2026-07-13 092616-2" src="https://github.com/user-attachments/assets/7451b9d3-655e-40e6-8490-36781dc14d48"; /> Even if user specified originally the green source magnet point, moving the source node will cause any of the orange magnet point can start to be in use to have 'the most optimal' connection. ### Feedback However, I can not confirm only the source magnet point is recomputed. <img width="750" height="130" alt="image" src="https://github.com/user-attachments/assets/bd1d5b9f-7c3c-47ba-a4fe-7474b11d1375"; /> In the screenshot above, when I start to move **middle** node, both **Edge A** target point and **Edge B** source point are dynamically recomputed to have best connection. **My personal opinion** - I like this ✅ , is this acceptable to other KIE members ❓ I will try forward this PR to more engineers to have their opinion **Doubts** - Are then the all magnet points (the blue points when however a node) needed anymore? - Are we able to add a playwright test for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
