tkobayas commented on code in PR #3665:
URL:
https://github.com/apache/incubator-kie-tools/pull/3665#discussion_r3619060553
##########
packages/drl-vscode-extension/package.json:
##########
@@ -0,0 +1,196 @@
+{
+ "name": "drl-vscode-extension",
+ "version": "0.0.0",
+ "description": "Edit DRL (Drools Rule Language) files",
+ "license": "Apache-2.0",
+ "publisher": "kie-group",
+ "keywords": [],
+ "homepage": "https://github.com/apache/incubator-kie-tools";,
+ "repository": {
+ "type": "git",
+ "url": "https://github.com/apache/incubator-kie-tools.git";
+ },
+ "bugs": {
+ "url": "https://github.com/apache/incubator-kie-tools/issues";
+ },
+ "main": "dist/extension/extension.js",
+ "scripts": {
+ "build:dev": "rimraf dist && webpack --env dev",
+ "build:prod": "rimraf dist && webpack && pnpm pack:prod",
+ "compile": "webpack",
+ "lint": "run-script-if --bool \"$(build-env linters.run)\" --then
\"kie-tools--eslint ./src\"",
+ "pack:prod": "vsce package --githubBranch main --no-dependencies -o
./dist/drl_vscode_extension_$npm_package_version.vsix",
+ "pretest": "pnpm build:dev && mvn -f src/testFixture/pom.xml -ntp compile
&& tsc -p tsconfig.test.json",
+ "test": "node ./out-test/test/runTest.js",
+ "watch": "export WEBPACK__sourceMaps=true; WEBPACK__minimize=false;
webpack --env dev"
+ },
+ "dependencies": {
+ "vscode-languageclient": "^9.0.1"
+ },
+ "devDependencies": {
+ "@kie-tools-core/webpack-base": "workspace:*",
+ "@kie-tools-scripts/build-env": "workspace:*",
+ "@kie-tools/drools-lsp": "workspace:*",
+ "@kie-tools/eslint": "workspace:*",
+ "@kie-tools/root-env": "workspace:*",
+ "@kie-tools/tsconfig": "workspace:*",
+ "@types/mocha": "^10.0.7",
+ "@types/vscode": "1.67.0",
Review Comment:
`"@types/vscode": "1.67.0",` is required to satisfy the syncpack version
check. In other words, `1.67.0` is required in this incubator-kie-tools repo
for now.
As vscode-languageclient 9 requires vscode 1.82+, we had set
`engines.vscode` to `^1.103.0`, This may look inconsistent, but it actually
works.
If we ever need to use APIs introduced after vscode 1.67, we can discuss
updating `@types/vscode` with the kie-tools team.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
