AnnJoy23 commented on code in PR #3679:
URL:
https://github.com/apache/incubator-kie-tools/pull/3679#discussion_r3641182348
##########
packages/maven-base/env/index.js:
##########
@@ -18,6 +18,7 @@
*/
const { varsWithName, composeEnv, getOrDefault } =
require("@kie-tools-scripts/build-env");
+const buildDeps = require("../../../repo/build-dependencies-versions.json");
Review Comment:
@tiagobento
Thank you for the clarification. Since build-dependencies-versions.json is
planned for removal, introducing a new dependency on it would be
counterproductive. I've reverted that change and retained the version directly
in env/index.js, making it the single source of truth.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
