tkobayas commented on PR #6813: URL: https://github.com/apache/incubator-kie-drools/pull/6813#issuecomment-5101548950
Hi @yesamer , https://github.com/apache/incubator-kie-drools/pull/6762 introduced `.gitattributes` which has the line: ``` * text eol=lf ``` It means text files must have LF at the end of lines, not CRLF. This PR fixes files which have CRLF. First, this PR is simply to comply with the policy. Second, from what I've observed, there are two issues caused by CRLF line endings. 1. if you modify and commit one of the CRLF files (e.g., `FireUntilHaltCommand.java`), `CI :: Build` would fail. See https://github.com/apache/incubator-kie-drools/pull/6814 . I wrote the reason in this comment https://github.com/apache/incubator-kie-drools/pull/6813#issuecomment-5001041289 2. if you clone incubator-kie-drools and copy the directory locally, the copied directory shows the CRLF files as "modified" even though you haven't modified them. Steps to reproduce: ``` $ mkdir 01-clone-repo $ cd 01-clone-repo $ git clone https://github.com/apache/incubator-kie-drools $ cd incubator-kie-drools $ git status (nothing shows up) $ cd ../../ $ mkdir 02-copy-repo $ cp -r 01-clone-repo/incubator-kie-drools 02-copy-repo $ cd 02-copy-repo/incubator-kie-drools $ git status (many "modified" files) ``` Actually, the "modified" status is the expected behavior according to `.gitattributes`. The real problem is that a freshly cloned repository doesn't report these files as modified in git status (likely because of git's "stat cache"), so many users never realize there's an issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
