drccrd commented on code in PR #3968:
URL:
https://github.com/apache/incubator-kie-tools/pull/3968#discussion_r3853984459
##########
scripts/bootstrap/link_packages_with_self.js:
##########
@@ -50,10 +50,10 @@ function selfLink(pkg, selfLinkPath) {
selfLinkPath
)} -> ${relTargetPath}`
);
- if (fs.existsSync(selfLinkPath)) {
+ if (fs.lstatSync(selfLinkPath, { throwIfNoEntry: false })) {
fs.unlinkSync(selfLinkPath);
}
- fs.symlinkSync(relTargetPath, selfLinkPath);
+ fs.symlinkSync(relTargetPath, selfLinkPath, process.platform === "win32" ?
"junction" : undefined);
Review Comment:
@tiagobento I checked the repo docs and there are various references to the
support (or lack thereof) of native windows, but I didn't see anything specific
to this point, and of course alternatives exist I could use (and have been
using until now) - let me know if you would prefer this removed, then I will
just keep the drl-vscode-extension changes in this branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
