tkobayas commented on PR #6860: URL: https://github.com/apache/incubator-kie/pull/6860#issuecomment-5489621533
Hi @tiagobento > I wonder if those partitions are the most optimal. It seems we have a big opportunity to break down kogito-apps and the default partition as well. The partition files are just a starting point. Certainly, we can break down kogito-apps and the default partition further, and that flexibility is one of the advantages of the partition approach. However, the current partitions look reasonably balanced (three of them take around one hour). So, could we do further tuning in a separate PR? > One thing that crossed my mind too: Are we sure that the sum of these partitions result in all the modules being built? In KIE Tools we added a guard clause for it that helped be confident that no module was being forgotten by bugs or misconfiguration. Thanks, I added the check following the kie-tools approach. > If we can extract the time each test takes from the logs, we can heuristically determine what's the best partition allocation by number of partitions and members of each partition. Yes, we can, and I think it would be an interesting exercise. Could we do that in a separate PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
