yesamer commented on code in PR #2245:
URL:
https://github.com/apache/incubator-kie-examples/pull/2245#discussion_r3948612467
##########
pom.xml:
##########
@@ -103,6 +103,8 @@
<!-- Reproducible builds -->
<project.build.outputTimestamp>2024-01-16T00:00:00Z</project.build.outputTimestamp>
<version.maven.artifact.plugin>3.4.1</version.maven.artifact.plugin>
+ <!-- JKube -->
+ <version.org.eclipse.jkube>1.4.0</version.org.eclipse.jkube>
Review Comment:
@nrknithin Can you explain the reason we need this?
##########
gradle-examples/kogito-quarkus-gradle-examples/dmn-quarkus-gradle/gradle.properties:
##########
@@ -1,10 +1,11 @@
#Gradle properties
-## 3.27.5.1 needed to support gradle 9.2
+## Quarkus 3.27+ is required for Gradle 9.2 support (wrapper: 9.2.1). Gradle
cannot inherit from the
+## Maven parent, so this pin is maintained by hand and must track the kie
stack (version.io.quarkus).
Review Comment:
@nrknithin I don't know if keeping this comment still makes sense, WDYT
@gitgabrio ?
##########
pom.xml:
##########
@@ -152,6 +154,23 @@
<skip>true</skip>
</configuration>
</plugin>
+ <!-- Kept pinned here for the Java and Gradle examples, which inherit
from this pom: failsafe must
+ track surefire (${version.surefire.plugin}), and the JKube
plugins must not resolve to LATEST. -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-failsafe-plugin</artifactId>
+ <version>${version.surefire.plugin}</version>
+ </plugin>
+ <plugin>
+ <groupId>org.eclipse.jkube</groupId>
+ <artifactId>kubernetes-maven-plugin</artifactId>
+ <version>${version.org.eclipse.jkube}</version>
+ </plugin>
+ <plugin>
+ <groupId>org.eclipse.jkube</groupId>
+ <artifactId>openshift-maven-plugin</artifactId>
+ <version>${version.org.eclipse.jkube}</version>
+ </plugin>
Review Comment:
@nrknithin Same?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
