Rikkola commented on code in PR #6909: URL: https://github.com/apache/incubator-kie/pull/6909#discussion_r3957465741
########## drools-test-coverage/test-compiler-integration/src/test/java/org/drools/mvel/integrationtests/phreak/B.java: ########## @@ -18,18 +18,30 @@ */ package org.drools.mvel.integrationtests.phreak; +import org.kie.api.definition.type.Expires; import org.kie.api.definition.type.Position; +import org.kie.api.definition.type.Role; +import org.kie.api.definition.type.Role.Type; +@Expires(value = "5s") +@Role(value = Type.EVENT) Review Comment: I made the change it will be better on the long run. Another thing is the Events do not actually need to be annotated at the moment. Reusing the CEP annotations is something that is not yet there, so there is no expiring of events at the moment. Even though it is likely a good feature for the future. The annotations were actually a left over I did for comparison between CEP and sequential. My plan is to do the comparison in a separate project in the future so there can be comparison of syntax, features and performance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
