drccrd commented on PR #4005: URL: https://github.com/apache/incubator-kie-tools/pull/4005#issuecomment-5752963767
@jomarko thank you very much for testing! These are critical points you identified - indeed the majority of the testing during development was conducted on traditional syntax, so RuleUnit and OOPath syntax weren't correctly represented. I have adjusted the logic in [3606543](https://github.com/apache/incubator-kie-tools/pull/4005/commits/3606543f9ef38220e5b1cfa16bb50cf319eb8e0f) and [b59e8fc](https://github.com/apache/incubator-kie-tools/pull/4005/commits/b59e8fc633f14daca9c76326c45f3ed299dc35b1) to keep OOpath expression chains without spaces, and add spaces between square brackets depending on the configurable 'parenPadding' to align with parentheses and braces. I got claude to build an additional check for any lost tokens during formatting, and ran the formatter across all drl files in incubator-kie and incubator-kie-tools and found a few bugs, and also a few supported syntax patterns I wasn't aware of. These have been addressed in the subsequent commits and added to the readme. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
