mariofusco commented on PR #7126: URL: https://github.com/apache/incubator-kie/pull/7126#issuecomment-5778473094
The guard that this pull request aims to introduce is not only useless, but also violates one of the core principle of drools code base: fail as fast as possible instead of hiding the dust under the carpet. If a tuple that is not there is going to be removed we want the code the fail with an exception instead of guarding the removal and propagate the error downstream where it will be harder to be investigated and fixed. Also note that the provided test doesn't demonstrate an actual bug of the engine but only create an unreal situation. If you think this could be a real problem of the engine please provide an integration test demonstrating it using drools rules. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
