tkobayas commented on PR #7127: URL: https://github.com/apache/incubator-kie/pull/7127#issuecomment-5809731427
@Thebas Thank you very much for reporting this issue and for the PR. First, I'd like to know whether `insert(fact, true)` is actually used in your real-world use cases. It is an internal method of `WorkingMemoryEntryPoint`, not a public method of `KieSession`. An old document mentions that this API is deprecated: https://docs.drools.org/7.4.1.Final/drools-docs/html_single/#__propertychangesupport (Although the method itself is not annotated with `@Deprecated`.) ``` The boolean parameter that was used in the insert() method in the Drools 4 API is deprecated and does not exist in the drools-api module. ``` If we limit the scope of the fix to `@propertyChangeSupport` only, the fix could be simpler. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
