Copilot commented on code in PR #7184:
URL: https://github.com/apache/incubator-kie/pull/7184#discussion_r4238261688
##########
kie-dmn/kie-dmn-backend/src/test/java/org/kie/dmn/backend/marshalling/v1_6/UnmarshalMarshalTest.java:
##########
@@ -106,6 +106,11 @@ void testv16_filter() throws Exception {
testRoundTripV16("org/kie/dmn/backend/marshalling/v1_6/",
"sampleFilter.dmn");
}
+ @Test
+ void testv16_inputValuesTypeRef() throws Exception {
+ testRoundTripV16("org/kie/dmn/backend/marshalling/v1_6/",
"inputValuesTypeRef.dmn");
Review Comment:
The v1.3–v1.5 `ExpressionConverter` implementations were changed
independently, but this regression test executes only the v1.6 marshaller. The
model tests do not cover XML serialization, so an earlier-version converter
could still drop `typeRef` unnoticed. Please add schema-valid round-trip
coverage for DMN 1.3, 1.4, and 1.5 (or equivalent parameterized cross-version
coverage).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
