Copilot commented on code in PR #4042:
URL:
https://github.com/apache/incubator-kie-tools/pull/4042#discussion_r4261889406
##########
packages/bpmn-editor/src/mutations/renameMessage.ts:
##########
@@ -65,7 +65,8 @@ export function renameMessage({
array[index].__$$element === "endEvent" ||
array[index].__$$element === "intermediateThrowEvent" ||
array[index].__$$element === "startEvent" ||
- array[index].__$$element === "intermediateCatchEvent"
+ array[index].__$$element === "intermediateCatchEvent" ||
+ array[index].__$$element === "boundaryEvent"
) {
Review Comment:
The same “supported event element types” condition appears duplicated across
multiple mutation files, and this PR demonstrates it’s easy to miss one (e.g.,
`boundaryEvent`). To avoid future omissions and reduce repetition, consider
centralizing these element-name checks into a shared helper/constant (e.g., a
`Set`/array + `includes` / `has`) reused by all rename/delete mutations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
