salome522 opened a new pull request, #7191: URL: https://github.com/apache/incubator-kie/pull/7191
Closes: #7188 When a subnetwork is shared, `doSubnetwork2` collects the memory of every sink. For the second and following sinks it checked the type of the first sink (`betaNode`) instead of the current one (`bns[i - 1]`). A `NotNode`/`ExistsNode` (`BetaMemory`) and an `AccumulateNode` (`AccumulateMemory`) sharing one subnetwork therefore failed with a `ClassCastException`, in either direction depending on the rule order. The fix is the one-word change in that check. The new tests in `SubnetworkTest` cover both rule orders, with and without a matching tuple, under both the non-executable and the executable model. Without the fix all four fail with the expected cast; with it they pass. `SubnetworkTest`, the other subnetwork test classes and `AccumulateTest` (compiler integration and executable model) pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
