eatmoreduck commented on PR #7278: URL: https://github.com/apache/incubator-kie/pull/7278#issuecomment-6756600035
Thanks @martinweiler — fair points all around, and #7280 is clearly the right fix. - The `ConcurrentModificationException` point is spot on: the loop in my change iterates the live view returned by `pi.getNodeInstances(false)`, and the first `cancel()` of a stale wrapper mutates the backing list mid-iteration via `removeNodeInstance()`. So it's not just a potential risk — it would throw the moment there's actually something to clean up. Good catch. - Agreed on the rest too: even with the iteration fixed, a sweep like this can't reliably tell stale wrappers from healthy ones (point 1), misses nested containers (point 3), and above all only addresses the residue — the id mismatch you fixed at the source in #7280 is the actual cause. I've gone through #7280 and it also fully explains the surviving wrapper in the #7274 reproducer. Closing this PR in favor of #7280 — thanks for the root-cause dig, and for the history pointer to ff5db7b047c (kie-issues#7162), which fills in exactly how the job ended up pointing at the virtual instance id. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
