gitgabrio commented on code in PR #7283:
URL: https://github.com/apache/incubator-kie/pull/7283#discussion_r4536002216
##########
kie-archetypes/kie-drools-exec-model-archetype/src/main/resources/archetype-resources/src/test/java/RuleTest.java:
##########
@@ -55,8 +55,8 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertTrue;
+import static org.junit.jupiter.api.Assertions.assertEquals;
Review Comment:
@Subhanshu20135
Please see above comment about usage of AssertJ assertions
##########
drools-scenario-simulation/drools-scenario-simulation-backend/src/test/java/org/drools/scenariosimulation/backend/fluent/DMNScenarioExecutableBuilderTest.java:
##########
@@ -41,7 +41,7 @@
import org.slf4j.LoggerFactory;
import static org.assertj.core.api.Assertions.assertThat;
-import static org.junit.Assert.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertThrows;
Review Comment:
Hi @Subhanshu20135
Please, do no use junit/jupiter assertions.
When we did the "jakarta" refactoring we sort of agreed to use AssertJ
assertions everywhere for their better "usability".
Regardless of this still being true or not, it is better to have consistency
overall the codebase. Thanks!
##########
kie-test-util/src/main/java/org/kie/test/util/TestStatusListener.java:
##########
@@ -114,47 +113,71 @@ private static String fullStackTrace(final ThreadInfo ti)
{
return sb.toString();
}
- @Override
- public void testRunStarted(final Description description) throws Exception
{
- write("testRunStarted", description);
+ private static boolean isTimeoutFailure(final Throwable throwable) {
Review Comment:
@Subhanshu20135
Could you please move private methods at the bottom of the class ? It is an
old but still valid Java Bean convention and makes the class easy to read,
since we are mostly interested in public/Test methods. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]