gitgabrio commented on code in PR #7272:
URL: https://github.com/apache/incubator-kie/pull/7272#discussion_r4538660447


##########
kogito-quarkus/addons/persistence/kafka/runtime/src/test/java/org/kie/kogito/persistence/kafka/KafkaProcessInstancesIT.java:
##########
@@ -83,7 +86,12 @@ public class KafkaProcessInstancesIT {
     KafkaStreamsStateListener listener;
 
     @BeforeEach
-    void start() {
+    void start() throws Exception {
+        // With Kafka Streams >= 4.2 the global table fails to initialize ("no 
partitions available") if its source topic
+        // does not exist yet, so create it before the topology starts.
+        try (Admin admin = 
Admin.create(singletonMap(ProducerConfig.BOOTSTRAP_SERVERS_CONFIG, 
kafka.getBootstrapServers()))) {

Review Comment:
   Hi @jaedonP 
   Please correctly manage the Exception thrown by `try` with a proper `catch` 
and removce the `throws Exception`, to simplify tracking and fixing of issues.
   As it currently is, an exception would resolve on a long stacktrace on build 
log, making it harder to read and follow.
   Please keep in mind that, in case of errors and when bugs have to be fixed, 
reading the logs is the starting point, so we must be carefull to not pollute 
them with unneeded noise
   Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to