This is an automated email from the ASF dual-hosted git repository.

tkobayas pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-kie.git


The following commit(s) were added to refs/heads/main by this push:
     new 9d217a54229 [incubator-kie#6938] Explain why a 
KieContainerSessionsPool rejects a stateless KieSessionModel (#7287)
9d217a54229 is described below

commit 9d217a54229ffc8657171a028ce51d1f24b2eee1
Author: ZIHAN DAI <[email protected]>
AuthorDate: Mon Nov 16 17:39:30 2026 +1100

    [incubator-kie#6938] Explain why a KieContainerSessionsPool rejects a 
stateless KieSessionModel (#7287)
    
    * [incubator-kie#6938] Allow KieContainerSessionsPool to create stateless 
sessions from a stateless KieSessionModel
    
    KieContainerSessionsPool.newStatelessKieSession(name) went through the
    same KieBase lookup as the stateful path, which rejects any session model
    of type STATELESS. A session declared as stateless in kmodule.xml could
    therefore never be obtained from a container sessions pool, while
    KieContainer.newStatelessKieSession(name) accepted it.
    
    Only reject a STATELESS model when the pool is asked for a stateful
    session.
    
    * [incubator-kie#6938] Explain why a sessions pool rejects a stateless 
KieSessionModel
    
    A KieContainerSessionsPool only pools sessions of a stateful
    KieSessionModel. Keep rejecting a stateless model, as before the
    previous commit, but say so in the error and point to
    KieContainer.newStatelessKieSession instead of reporting "Trying to
    create a stateful KieSession from a stateless KieSessionModel" to a
    caller that asked for a stateless session.
---
 .../kie/builder/impl/KieContainerImpl.java         |  4 ++++
 .../integrationtests/session/SessionsPoolTest.java | 22 ++++++++++++++++++++++
 2 files changed, 26 insertions(+)

diff --git 
a/drools-compiler/src/main/java/org/drools/compiler/kie/builder/impl/KieContainerImpl.java
 
b/drools-compiler/src/main/java/org/drools/compiler/kie/builder/impl/KieContainerImpl.java
index 6b094b08441..23c1fb6b840 100644
--- 
a/drools-compiler/src/main/java/org/drools/compiler/kie/builder/impl/KieContainerImpl.java
+++ 
b/drools-compiler/src/main/java/org/drools/compiler/kie/builder/impl/KieContainerImpl.java
@@ -543,6 +543,10 @@ public class KieContainerImpl
             log.error("Unknown KieSession name: " + kSessionName);
             return null;
         }
+        if (kSessionModel.getType() == 
KieSessionModel.KieSessionType.STATELESS) {
+            throw new RuntimeException("KieSessionModel " + 
kSessionModel.getName() + " is stateless, but a KieContainerSessionsPool only 
pools sessions of a stateful KieSessionModel. " +
+                                       "Use 
KieContainer.newStatelessKieSession(\"" + kSessionModel.getName() + "\") for a 
stateless session.");
+        }
         InternalKnowledgeBase kBase = (InternalKnowledgeBase) 
getKieBaseFromKieSessionModel(kSessionModel);
         return kBase == null ? null : new StatefulSessionPool(kBase, 
initialSize, () -> {
             SessionConfiguration sessConf = conf != null ? 
conf.as(SessionConfiguration.KEY) : 
kBase.getSessionConfiguration().as(SessionConfiguration.KEY);
diff --git 
a/drools-test-coverage/test-compiler-integration/src/test/java/org/drools/mvel/integrationtests/session/SessionsPoolTest.java
 
b/drools-test-coverage/test-compiler-integration/src/test/java/org/drools/mvel/integrationtests/session/SessionsPoolTest.java
index 5eb278bb514..5af5a055e62 100644
--- 
a/drools-test-coverage/test-compiler-integration/src/test/java/org/drools/mvel/integrationtests/session/SessionsPoolTest.java
+++ 
b/drools-test-coverage/test-compiler-integration/src/test/java/org/drools/mvel/integrationtests/session/SessionsPoolTest.java
@@ -19,6 +19,7 @@
 package org.drools.mvel.integrationtests.session;
 
 import java.util.ArrayList;
+import java.util.HashMap;
 import java.util.List;
 import java.util.concurrent.CompletionService;
 import java.util.concurrent.ExecutionException;
@@ -36,6 +37,7 @@ import org.drools.mvel.compiler.FactB;
 import org.drools.mvel.compiler.FactC;
 import org.drools.testcoverage.common.util.KieBaseTestConfiguration;
 import org.drools.testcoverage.common.util.KieBaseUtil;
+import org.drools.testcoverage.common.util.KieSessionTestConfiguration;
 import org.drools.testcoverage.common.util.KieUtil;
 import org.drools.testcoverage.common.util.TestParametersUtil2;
 import org.junit.jupiter.params.ParameterizedTest;
@@ -57,6 +59,7 @@ import org.kie.internal.event.rule.RuleEventListener;
 import org.kie.internal.event.rule.RuleEventManager;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
 import static org.assertj.core.api.Assertions.fail;
 
 public class SessionsPoolTest {
@@ -208,6 +211,25 @@ public class SessionsPoolTest {
         assertThat(list.size()).isEqualTo(1);
     }
 
+    @ParameterizedTest(name = "KieBase type={0}")
+    @MethodSource("parameters")
+    public void 
testKieSessionsPoolWithStatelessKieSessionModel(KieBaseTestConfiguration 
kieBaseTestConfiguration) {
+        // incubator-kie#6938: a pool only holds stateful sessions, so a 
stateless model gets a clear error
+        final KieModule kieModule = 
KieUtil.getKieModuleFromDrls(KieUtil.generateReleaseId("test"), 
kieBaseTestConfiguration,
+                                                                 
KieSessionTestConfiguration.STATELESS_REALTIME, new HashMap<>(),
+                                                                 "rule R1 when 
then end\n");
+        KieContainerSessionsPool pool = 
KieServices.get().newKieContainer(kieModule.getReleaseId()).newKieSessionsPool( 
1 );
+        try {
+            String name = KieSessionTestConfiguration.KIE_SESSION_MODEL_NAME;
+            String expected = "KieSessionModel " + name + " is stateless, but 
a KieContainerSessionsPool only pools sessions of a stateful KieSessionModel. " 
+
+                              "Use KieContainer.newStatelessKieSession(\"" + 
name + "\") for a stateless session.";
+            assertThatThrownBy(() -> pool.newStatelessKieSession( name 
)).hasMessage(expected);
+            assertThatThrownBy(() -> pool.newKieSession( name 
)).hasMessage(expected);
+        } finally {
+            pool.shutdown();
+        }
+    }
+
     private KieContainer getKieContainer(KieBaseTestConfiguration 
kieBaseTestConfiguration) {
         String drl =
                 "global java.util.List list\n" +


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to