Repository: knox Updated Branches: refs/heads/master 197e9960d -> 0edaec6e3
KNOX-466: Log exception stack traces at INFO level when they reach gateway servlet Project: http://git-wip-us.apache.org/repos/asf/knox/repo Commit: http://git-wip-us.apache.org/repos/asf/knox/commit/0edaec6e Tree: http://git-wip-us.apache.org/repos/asf/knox/tree/0edaec6e Diff: http://git-wip-us.apache.org/repos/asf/knox/diff/0edaec6e Branch: refs/heads/master Commit: 0edaec6e33f68f6fe68b2e63e6f867401f194c2d Parents: 197e996 Author: Kevin Minder <[email protected]> Authored: Mon Nov 3 17:20:52 2014 -0500 Committer: Kevin Minder <[email protected]> Committed: Mon Nov 3 17:20:52 2014 -0500 ---------------------------------------------------------------------- .../main/java/org/apache/hadoop/gateway/GatewayMessages.java | 6 +++--- .../main/java/org/apache/hadoop/gateway/GatewayServlet.java | 3 +++ 2 files changed, 6 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/knox/blob/0edaec6e/gateway-server/src/main/java/org/apache/hadoop/gateway/GatewayMessages.java ---------------------------------------------------------------------- diff --git a/gateway-server/src/main/java/org/apache/hadoop/gateway/GatewayMessages.java b/gateway-server/src/main/java/org/apache/hadoop/gateway/GatewayMessages.java index 40aaa8d..9325c02 100644 --- a/gateway-server/src/main/java/org/apache/hadoop/gateway/GatewayMessages.java +++ b/gateway-server/src/main/java/org/apache/hadoop/gateway/GatewayMessages.java @@ -184,11 +184,11 @@ public interface GatewayMessages { @Message( level = MessageLevel.ERROR, text = "Failed to initialize contribution: {0}" ) void failedToInitializeContribution( @StackTrace( level = MessageLevel.DEBUG ) Exception e ); - @Message( level = MessageLevel.ERROR, text = "Failed to initialize servlet instace: {0}" ) + @Message( level = MessageLevel.ERROR, text = "Failed to initialize servlet instance: {0}" ) void failedToInitializeServletInstace( @StackTrace( level = MessageLevel.DEBUG ) Exception e ); - @Message( level = MessageLevel.ERROR, text = "Failed to execute filter: {0}" ) - void failedToExecuteFilter( @StackTrace( level = MessageLevel.DEBUG ) Throwable t ); + @Message( level = MessageLevel.ERROR, text = "Gateway processing failed: {0}" ) + void failedToExecuteFilter( @StackTrace( level = MessageLevel.INFO ) Throwable t ); @Message( level = MessageLevel.ERROR, text = "Failed to load topology {0}: {1}") void failedToLoadTopology( String fileName, @StackTrace( level = MessageLevel.DEBUG ) Exception e ); http://git-wip-us.apache.org/repos/asf/knox/blob/0edaec6e/gateway-server/src/main/java/org/apache/hadoop/gateway/GatewayServlet.java ---------------------------------------------------------------------- diff --git a/gateway-server/src/main/java/org/apache/hadoop/gateway/GatewayServlet.java b/gateway-server/src/main/java/org/apache/hadoop/gateway/GatewayServlet.java index 27febb5..6eea100 100644 --- a/gateway-server/src/main/java/org/apache/hadoop/gateway/GatewayServlet.java +++ b/gateway-server/src/main/java/org/apache/hadoop/gateway/GatewayServlet.java @@ -125,6 +125,9 @@ public class GatewayServlet implements Servlet { } catch( ServletException e ) { LOG.failedToExecuteFilter( e ); throw e; + } catch( RuntimeException e ) { + LOG.failedToExecuteFilter( e ); + throw e; } } else { ((HttpServletResponse)servletResponse).setStatus( HttpServletResponse.SC_SERVICE_UNAVAILABLE );
