Repository: knox Updated Branches: refs/heads/master 87fcd4d65 -> 539557c90
KNOX-603: Coverity: Potential resource leak in BaseKeystoreService.createKeystore Project: http://git-wip-us.apache.org/repos/asf/knox/repo Commit: http://git-wip-us.apache.org/repos/asf/knox/commit/539557c9 Tree: http://git-wip-us.apache.org/repos/asf/knox/tree/539557c9 Diff: http://git-wip-us.apache.org/repos/asf/knox/diff/539557c9 Branch: refs/heads/master Commit: 539557c902404529c4636bfe0425ba44980cc177 Parents: 87fcd4d Author: Kevin Minder <kevin.min...@hortonworks.com> Authored: Wed Sep 30 16:49:51 2015 -0400 Committer: Kevin Minder <kevin.min...@hortonworks.com> Committed: Wed Sep 30 16:49:51 2015 -0400 ---------------------------------------------------------------------- CHANGES | 1 + .../hadoop/gateway/services/security/impl/BaseKeystoreService.java | 1 + 2 files changed, 2 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/knox/blob/539557c9/CHANGES ---------------------------------------------------------------------- diff --git a/CHANGES b/CHANGES index 51925ad..0a851ab 100644 --- a/CHANGES +++ b/CHANGES @@ -24,6 +24,7 @@ Release Notes - Apache Knox - Version 0.7.0 * [KNOX-598] - Concurrent JDBC clients via KNOX to Kerberized HiveServer2 causes HTTP 401 error (due to Kerberos Replay attack error) * [KNOX-599] - Template with {**} in queries are expanded with =null for query params without a value * [KNOX-601] - Knox test failures on windows + * [KNOX-603] - Coverity: Potential resource leak in BaseKeystoreService.createKeystore ------------------------------------------------------------------------------ Release Notes - Apache Knox - Version 0.6.0 http://git-wip-us.apache.org/repos/asf/knox/blob/539557c9/gateway-spi/src/main/java/org/apache/hadoop/gateway/services/security/impl/BaseKeystoreService.java ---------------------------------------------------------------------- diff --git a/gateway-spi/src/main/java/org/apache/hadoop/gateway/services/security/impl/BaseKeystoreService.java b/gateway-spi/src/main/java/org/apache/hadoop/gateway/services/security/impl/BaseKeystoreService.java index ce9a36c..0f1b611 100644 --- a/gateway-spi/src/main/java/org/apache/hadoop/gateway/services/security/impl/BaseKeystoreService.java +++ b/gateway-spi/src/main/java/org/apache/hadoop/gateway/services/security/impl/BaseKeystoreService.java @@ -94,6 +94,7 @@ public class BaseKeystoreService { KeyStore ks = KeyStore.getInstance(keystoreType); ks.load( null, null ); ks.store( out, masterService.getMasterSecret() ); + out.close(); } catch (KeyStoreException e) { LOG.failedToCreateKeystore( filename, keystoreType, e ); throw new KeystoreServiceException(e);
