Repository: kudu
Updated Branches:
refs/heads/master 934e34328 -> 953a7070f
[iwyu] minor cleanup after LLVM/IWYU update
It seems IWYU started output some new warning since LLVM/IWYU was
upgraded recently. I found that while looking at IWYU warnings output
while processing HMS-related code. This small update cleans up
all warnings from all files we currently check with IWYU tool.
As an additional update, I switched client/error-internal.{cc,h}
from gscoped_ptr to std::unique_ptr.
This changelist does not contain any functional changes.
Change-Id: I6314e0df6273a602c71c728a7e4126a8d2edddfd
Reviewed-on: http://gerrit.cloudera.org:8080/10130
Tested-by: Alexey Serbin <aser...@cloudera.com>
Reviewed-by: Alexey Serbin <aser...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/767005c5
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/767005c5
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/767005c5
Branch: refs/heads/master
Commit: 767005c5760f5664e8c2ac8508ad3181fe7a27ca
Parents: 934e343
Author: Alexey Serbin <aser...@cloudera.com>
Authored: Thu Apr 19 16:45:49 2018 -0700
Committer: Alexey Serbin <aser...@cloudera.com>
Committed: Fri Apr 20 04:36:38 2018 +0000
----------------------------------------------------------------------
src/kudu/benchmarks/tpch/tpch_real_world.cc | 1 -
src/kudu/cfile/cfile_reader.cc | 1 -
src/kudu/client/batcher.cc | 1 -
src/kudu/client/client.cc | 3 +--
src/kudu/client/error-internal.cc | 7 ++-----
src/kudu/client/error-internal.h | 10 +++++-----
src/kudu/client/error_collector.cc | 1 -
src/kudu/codegen/codegen-test.cc | 1 -
src/kudu/common/encoded_key.cc | 1 -
src/kudu/common/partition_pruner-test.cc | 1 -
src/kudu/common/scan_spec-test.cc | 1 -
src/kudu/consensus/consensus_peers-test.cc | 1 -
src/kudu/consensus/consensus_peers.cc | 1 -
src/kudu/consensus/leader_election-test.cc | 1 -
src/kudu/consensus/leader_election.cc | 1 -
src/kudu/consensus/log-test.cc | 1 -
src/kudu/consensus/log.h | 2 +-
src/kudu/consensus/peer_manager.cc | 1 -
src/kudu/consensus/raft_consensus.cc | 1 -
src/kudu/consensus/raft_consensus_quorum-test.cc | 1 -
src/kudu/integration-tests/create-table-itest.cc | 1 -
.../integration-tests/raft_consensus_nonvoter-itest.cc | 4 ++--
src/kudu/master/catalog_manager.cc | 1 -
src/kudu/master/master.cc | 1 -
src/kudu/master/sys_catalog.cc | 1 -
src/kudu/mini-cluster/external_mini_cluster-test.cc | 1 +
src/kudu/rpc/connection.cc | 1 -
src/kudu/rpc/inbound_call.cc | 1 -
src/kudu/rpc/messenger.cc | 1 -
src/kudu/rpc/mt-rpc-test.cc | 1 -
src/kudu/rpc/negotiation-test.cc | 1 +
src/kudu/rpc/outbound_call.cc | 1 -
src/kudu/rpc/service_pool.cc | 1 -
src/kudu/security/tls_context.h | 5 +++--
src/kudu/server/rpc_server.cc | 1 -
src/kudu/server/server_base.cc | 1 -
src/kudu/tablet/compaction.cc | 1 -
src/kudu/tablet/diskrowset-test.cc | 1 -
src/kudu/tablet/memrowset.cc | 1 -
src/kudu/tablet/row_op.cc | 1 -
src/kudu/tablet/rowset.h | 1 -
src/kudu/tablet/rowset_info.cc | 1 -
src/kudu/tablet/svg_dump.cc | 1 -
src/kudu/tablet/tablet-test.cc | 1 -
src/kudu/tablet/tablet.cc | 1 -
src/kudu/tablet/tablet_bootstrap-test.cc | 1 -
src/kudu/tablet/tablet_history_gc-test.cc | 1 -
src/kudu/tablet/tablet_metadata.cc | 1 -
src/kudu/tablet/tablet_metadata.h | 2 +-
src/kudu/tablet/tablet_replica-test.cc | 1 -
src/kudu/tablet/tablet_replica.cc | 1 -
src/kudu/tablet/transactions/transaction_driver.cc | 1 -
src/kudu/tablet/transactions/transaction_tracker-test.cc | 1 -
src/kudu/tablet/transactions/write_transaction.cc | 1 -
src/kudu/tools/ksck_remote.cc | 10 +++++++++-
src/kudu/tools/tool_action_remote_replica.cc | 1 -
src/kudu/tserver/tablet_copy_source_session-test.cc | 1 -
src/kudu/tserver/tablet_server.cc | 1 -
src/kudu/tserver/tablet_service.cc | 1 -
src/kudu/util/callback_bind-test.cc | 1 -
src/kudu/util/debug/trace_event_impl.cc | 1 -
src/kudu/util/env.h | 1 +
src/kudu/util/object_pool-test.cc | 1 -
src/kudu/util/once.h | 1 +
src/kudu/util/trace_metrics.h | 1 -
65 files changed, 28 insertions(+), 72 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/benchmarks/tpch/tpch_real_world.cc
----------------------------------------------------------------------
diff --git a/src/kudu/benchmarks/tpch/tpch_real_world.cc
b/src/kudu/benchmarks/tpch/tpch_real_world.cc
index 03a25f1..1a40872 100644
--- a/src/kudu/benchmarks/tpch/tpch_real_world.cc
+++ b/src/kudu/benchmarks/tpch/tpch_real_world.cc
@@ -64,7 +64,6 @@
#include "kudu/client/schema.h"
#include "kudu/common/partial_row.h"
#include "kudu/gutil/gscoped_ptr.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/ref_counted.h"
#include "kudu/gutil/stl_util.h"
#include "kudu/gutil/stringprintf.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/cfile/cfile_reader.cc
----------------------------------------------------------------------
diff --git a/src/kudu/cfile/cfile_reader.cc b/src/kudu/cfile/cfile_reader.cc
index 19323ee..60b7d19 100644
--- a/src/kudu/cfile/cfile_reader.cc
+++ b/src/kudu/cfile/cfile_reader.cc
@@ -46,7 +46,6 @@
#include "kudu/common/types.h"
#include "kudu/gutil/basictypes.h"
#include "kudu/gutil/gscoped_ptr.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/stringprintf.h"
#include "kudu/gutil/strings/substitute.h"
#include "kudu/util/array_view.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/client/batcher.cc
----------------------------------------------------------------------
diff --git a/src/kudu/client/batcher.cc b/src/kudu/client/batcher.cc
index 6e30970..0710f9a 100644
--- a/src/kudu/client/batcher.cc
+++ b/src/kudu/client/batcher.cc
@@ -50,7 +50,6 @@
#include "kudu/gutil/bind_helpers.h"
#include "kudu/gutil/gscoped_ptr.h"
#include "kudu/gutil/map-util.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/stl_util.h"
#include "kudu/gutil/strings/substitute.h"
#include "kudu/rpc/connection.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/client/client.cc
----------------------------------------------------------------------
diff --git a/src/kudu/client/client.cc b/src/kudu/client/client.cc
index 612fc18..524d2a9 100644
--- a/src/kudu/client/client.cc
+++ b/src/kudu/client/client.cc
@@ -67,7 +67,6 @@
#include "kudu/gutil/bind_helpers.h"
#include "kudu/gutil/casts.h"
#include "kudu/gutil/gscoped_ptr.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/ref_counted.h"
#include "kudu/gutil/stl_util.h"
#include "kudu/gutil/strings/numbers.h"
@@ -913,7 +912,7 @@ bool KuduError::was_possibly_successful() const {
KuduError::KuduError(KuduWriteOperation* failed_op,
const Status& status)
- : data_(new KuduError::Data(gscoped_ptr<KuduWriteOperation>(failed_op),
+ : data_(new KuduError::Data(unique_ptr<KuduWriteOperation>(failed_op),
status)) {
}
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/client/error-internal.cc
----------------------------------------------------------------------
diff --git a/src/kudu/client/error-internal.cc
b/src/kudu/client/error-internal.cc
index 74abc6b..eea90a2 100644
--- a/src/kudu/client/error-internal.cc
+++ b/src/kudu/client/error-internal.cc
@@ -17,18 +17,15 @@
#include "kudu/client/error-internal.h"
-#include <type_traits>
+#include <memory>
#include <utility>
-#include "kudu/client/write_op.h" // IWYU pragma: keep
-#include "kudu/gutil/gscoped_ptr.h"
-#include "kudu/gutil/move.h"
#include "kudu/util/status.h"
namespace kudu {
namespace client {
-KuduError::Data::Data(gscoped_ptr<KuduWriteOperation> failed_op,
+KuduError::Data::Data(std::unique_ptr<KuduWriteOperation> failed_op,
Status status) :
failed_op_(std::move(failed_op)),
status_(std::move(status)) {
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/client/error-internal.h
----------------------------------------------------------------------
diff --git a/src/kudu/client/error-internal.h b/src/kudu/client/error-internal.h
index 11f3720..11bd1b6 100644
--- a/src/kudu/client/error-internal.h
+++ b/src/kudu/client/error-internal.h
@@ -17,8 +17,10 @@
#ifndef KUDU_CLIENT_ERROR_INTERNAL_H
#define KUDU_CLIENT_ERROR_INTERNAL_H
+#include <memory>
+
#include "kudu/client/client.h"
-#include "kudu/gutil/gscoped_ptr.h"
+#include "kudu/client/write_op.h"
#include "kudu/gutil/macros.h"
#include "kudu/util/status.h"
@@ -26,14 +28,12 @@ namespace kudu {
namespace client {
-class KuduWriteOperation;
-
class KuduError::Data {
public:
- Data(gscoped_ptr<KuduWriteOperation> failed_op, Status error);
+ Data(std::unique_ptr<KuduWriteOperation> failed_op, Status error);
~Data() = default;
- gscoped_ptr<KuduWriteOperation> failed_op_;
+ std::unique_ptr<KuduWriteOperation> failed_op_;
Status status_;
DISALLOW_COPY_AND_ASSIGN(Data);
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/client/error_collector.cc
----------------------------------------------------------------------
diff --git a/src/kudu/client/error_collector.cc
b/src/kudu/client/error_collector.cc
index 3455cbb..344b9ee 100644
--- a/src/kudu/client/error_collector.cc
+++ b/src/kudu/client/error_collector.cc
@@ -24,7 +24,6 @@
#include "kudu/client/client.h"
#include "kudu/client/error-internal.h"
#include "kudu/client/write_op.h"
-#include "kudu/gutil/gscoped_ptr.h"
#include "kudu/gutil/stl_util.h"
#include "kudu/gutil/strings/substitute.h"
#include "kudu/util/status.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/codegen/codegen-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/codegen/codegen-test.cc b/src/kudu/codegen/codegen-test.cc
index 13540e3..2aace58 100644
--- a/src/kudu/codegen/codegen-test.cc
+++ b/src/kudu/codegen/codegen-test.cc
@@ -36,7 +36,6 @@
#include "kudu/common/rowblock.h"
#include "kudu/common/schema.h"
#include "kudu/gutil/gscoped_ptr.h"
-#include "kudu/gutil/macros.h"
#include "kudu/gutil/ref_counted.h"
#include "kudu/gutil/singleton.h"
#include "kudu/util/logging_test_util.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/common/encoded_key.cc
----------------------------------------------------------------------
diff --git a/src/kudu/common/encoded_key.cc b/src/kudu/common/encoded_key.cc
index b844dd9..6ae2fe5 100644
--- a/src/kudu/common/encoded_key.cc
+++ b/src/kudu/common/encoded_key.cc
@@ -27,7 +27,6 @@
#include "kudu/common/row.h"
#include "kudu/common/schema.h"
#include "kudu/common/types.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/port.h"
#include "kudu/util/logging.h"
#include "kudu/util/memory/arena.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/common/partition_pruner-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/common/partition_pruner-test.cc
b/src/kudu/common/partition_pruner-test.cc
index 39f0e6a..19690a5 100644
--- a/src/kudu/common/partition_pruner-test.cc
+++ b/src/kudu/common/partition_pruner-test.cc
@@ -38,7 +38,6 @@
#include "kudu/common/scan_spec.h"
#include "kudu/common/schema.h"
#include "kudu/gutil/gscoped_ptr.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/strings/substitute.h"
#include "kudu/util/auto_release_pool.h"
#include "kudu/util/memory/arena.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/common/scan_spec-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/common/scan_spec-test.cc
b/src/kudu/common/scan_spec-test.cc
index e24f9d2..8835dc7 100644
--- a/src/kudu/common/scan_spec-test.cc
+++ b/src/kudu/common/scan_spec-test.cc
@@ -36,7 +36,6 @@
#include "kudu/common/schema.h"
#include "kudu/gutil/gscoped_ptr.h"
#include "kudu/gutil/map-util.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/strings/stringpiece.h"
#include "kudu/util/auto_release_pool.h"
#include "kudu/util/memory/arena.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/consensus/consensus_peers-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/consensus_peers-test.cc
b/src/kudu/consensus/consensus_peers-test.cc
index f10cb34..37427c6 100644
--- a/src/kudu/consensus/consensus_peers-test.cc
+++ b/src/kudu/consensus/consensus_peers-test.cc
@@ -42,7 +42,6 @@
#include "kudu/consensus/time_manager.h"
#include "kudu/fs/fs_manager.h"
#include "kudu/gutil/gscoped_ptr.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/port.h"
#include "kudu/gutil/ref_counted.h"
#include "kudu/rpc/messenger.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/consensus/consensus_peers.cc
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/consensus_peers.cc
b/src/kudu/consensus/consensus_peers.cc
index 8f3dadd..dbab333 100644
--- a/src/kudu/consensus/consensus_peers.cc
+++ b/src/kudu/consensus/consensus_peers.cc
@@ -40,7 +40,6 @@
#include "kudu/consensus/opid_util.h"
#include "kudu/gutil/gscoped_ptr.h"
#include "kudu/gutil/macros.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/port.h"
#include "kudu/gutil/strings/substitute.h"
#include "kudu/rpc/periodic.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/consensus/leader_election-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/leader_election-test.cc
b/src/kudu/consensus/leader_election-test.cc
index 1dc26d9..ffe72c2 100644
--- a/src/kudu/consensus/leader_election-test.cc
+++ b/src/kudu/consensus/leader_election-test.cc
@@ -38,7 +38,6 @@
#include "kudu/gutil/casts.h"
#include "kudu/gutil/gscoped_ptr.h"
#include "kudu/gutil/map-util.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/ref_counted.h"
#include "kudu/gutil/stl_util.h"
#include "kudu/gutil/strings/substitute.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/consensus/leader_election.cc
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/leader_election.cc
b/src/kudu/consensus/leader_election.cc
index b8cbddc..dfb38d1 100644
--- a/src/kudu/consensus/leader_election.cc
+++ b/src/kudu/consensus/leader_election.cc
@@ -31,7 +31,6 @@
#include "kudu/gutil/bind.h"
#include "kudu/gutil/callback.h"
#include "kudu/gutil/map-util.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/port.h"
#include "kudu/gutil/stl_util.h"
#include "kudu/gutil/strings/join.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/consensus/log-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/log-test.cc b/src/kudu/consensus/log-test.cc
index 3d56b96..24fcc29 100644
--- a/src/kudu/consensus/log-test.cc
+++ b/src/kudu/consensus/log-test.cc
@@ -46,7 +46,6 @@
#include "kudu/consensus/opid_util.h"
#include "kudu/fs/fs_manager.h"
#include "kudu/gutil/gscoped_ptr.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/ref_counted.h"
#include "kudu/gutil/stl_util.h"
#include "kudu/gutil/strings/substitute.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/consensus/log.h
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/log.h b/src/kudu/consensus/log.h
index aaeb769..73138e2 100644
--- a/src/kudu/consensus/log.h
+++ b/src/kudu/consensus/log.h
@@ -36,7 +36,7 @@
#include "kudu/consensus/log_util.h"
#include "kudu/consensus/opid.pb.h"
#include "kudu/consensus/ref_counted_replicate.h"
-#include "kudu/gutil/callback.h"
+#include "kudu/gutil/callback.h" // IWYU pragma: keep
#include "kudu/gutil/gscoped_ptr.h"
#include "kudu/gutil/macros.h"
#include "kudu/gutil/ref_counted.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/consensus/peer_manager.cc
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/peer_manager.cc
b/src/kudu/consensus/peer_manager.cc
index 55668d5..2892c18 100644
--- a/src/kudu/consensus/peer_manager.cc
+++ b/src/kudu/consensus/peer_manager.cc
@@ -30,7 +30,6 @@
#include "kudu/consensus/metadata.pb.h"
#include "kudu/gutil/gscoped_ptr.h"
#include "kudu/gutil/map-util.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/port.h"
#include "kudu/gutil/strings/substitute.h"
#include "kudu/util/pb_util.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/consensus/raft_consensus.cc
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/raft_consensus.cc
b/src/kudu/consensus/raft_consensus.cc
index 09cbe12..027a64c 100644
--- a/src/kudu/consensus/raft_consensus.cc
+++ b/src/kudu/consensus/raft_consensus.cc
@@ -48,7 +48,6 @@
#include "kudu/consensus/quorum_util.h"
#include "kudu/gutil/bind.h"
#include "kudu/gutil/map-util.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/port.h"
#include "kudu/gutil/stl_util.h"
#include "kudu/gutil/stringprintf.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/consensus/raft_consensus_quorum-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/raft_consensus_quorum-test.cc
b/src/kudu/consensus/raft_consensus_quorum-test.cc
index 9534f08..4467c09 100644
--- a/src/kudu/consensus/raft_consensus_quorum-test.cc
+++ b/src/kudu/consensus/raft_consensus_quorum-test.cc
@@ -59,7 +59,6 @@
#include "kudu/gutil/casts.h"
#include "kudu/gutil/gscoped_ptr.h"
#include "kudu/gutil/map-util.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/ref_counted.h"
#include "kudu/gutil/stl_util.h"
#include "kudu/gutil/strings/strcat.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/integration-tests/create-table-itest.cc
----------------------------------------------------------------------
diff --git a/src/kudu/integration-tests/create-table-itest.cc
b/src/kudu/integration-tests/create-table-itest.cc
index 1bed8ff..b7d4da8 100644
--- a/src/kudu/integration-tests/create-table-itest.cc
+++ b/src/kudu/integration-tests/create-table-itest.cc
@@ -23,7 +23,6 @@
#include <ostream>
#include <set>
#include <string>
-#include <type_traits>
#include <utility>
#include <vector>
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
----------------------------------------------------------------------
diff --git a/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
b/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
index 6a5bd20..de29869 100644
--- a/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
+++ b/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
@@ -258,7 +258,7 @@ TEST_F(RaftConsensusNonVoterITest,
GetTableAndTabletLocations) {
ASSERT_OK(WaitForNumTabletsOnTS(
new_replica, 1, kTimeout, nullptr, tablet::RUNNING));
- const auto count_roles = [this](const TabletLocationsPB& tablet_locations,
+ const auto count_roles = [](const TabletLocationsPB& tablet_locations,
int* num_leaders, int* num_followers, int* num_learners) {
*num_leaders = 0;
*num_followers = 0;
@@ -363,7 +363,7 @@ TEST_F(RaftConsensusNonVoterITest, ReplicaMatchPolicy) {
ASSERT_OK(WaitForNumTabletsOnTS(
new_replica, 1, kTimeout, nullptr, tablet::RUNNING));
- auto count_replicas = [this](KuduTable* table, size_t* count) {
+ auto count_replicas = [](KuduTable* table, size_t* count) {
vector<KuduScanToken*> tokens;
ElementDeleter deleter(&tokens);
KuduScanTokenBuilder builder(table);
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/master/catalog_manager.cc
----------------------------------------------------------------------
diff --git a/src/kudu/master/catalog_manager.cc
b/src/kudu/master/catalog_manager.cc
index 0a0043b..1c2eefd 100644
--- a/src/kudu/master/catalog_manager.cc
+++ b/src/kudu/master/catalog_manager.cc
@@ -84,7 +84,6 @@
#include "kudu/gutil/bind_helpers.h"
#include "kudu/gutil/macros.h"
#include "kudu/gutil/map-util.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/port.h"
#include "kudu/gutil/ref_counted.h"
#include "kudu/gutil/strings/escaping.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/master/master.cc
----------------------------------------------------------------------
diff --git a/src/kudu/master/master.cc b/src/kudu/master/master.cc
index 41bb27e..a6210e8 100644
--- a/src/kudu/master/master.cc
+++ b/src/kudu/master/master.cc
@@ -37,7 +37,6 @@
#include "kudu/fs/fs_manager.h"
#include "kudu/gutil/bind.h"
#include "kudu/gutil/bind_helpers.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/strings/substitute.h"
#include "kudu/master/catalog_manager.h"
#include "kudu/master/master.pb.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/master/sys_catalog.cc
----------------------------------------------------------------------
diff --git a/src/kudu/master/sys_catalog.cc b/src/kudu/master/sys_catalog.cc
index 355b8f6..dc8cba7 100644
--- a/src/kudu/master/sys_catalog.cc
+++ b/src/kudu/master/sys_catalog.cc
@@ -59,7 +59,6 @@
#include "kudu/gutil/bind.h"
#include "kudu/gutil/bind_helpers.h"
#include "kudu/gutil/gscoped_ptr.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/port.h"
#include "kudu/gutil/strings/join.h"
#include "kudu/gutil/strings/substitute.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/mini-cluster/external_mini_cluster-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/mini-cluster/external_mini_cluster-test.cc
b/src/kudu/mini-cluster/external_mini_cluster-test.cc
index 8cd357c..2df19b7 100644
--- a/src/kudu/mini-cluster/external_mini_cluster-test.cc
+++ b/src/kudu/mini-cluster/external_mini_cluster-test.cc
@@ -16,6 +16,7 @@
// under the License.
#include <iosfwd>
+#include <ostream>
#include <string>
#include <utility>
#include <vector>
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/rpc/connection.cc
----------------------------------------------------------------------
diff --git a/src/kudu/rpc/connection.cc b/src/kudu/rpc/connection.cc
index 7332b50..1632dd3 100644
--- a/src/kudu/rpc/connection.cc
+++ b/src/kudu/rpc/connection.cc
@@ -31,7 +31,6 @@
#include <glog/logging.h>
#include "kudu/gutil/map-util.h"
-#include "kudu/gutil/move.h"
#include "kudu/util/slice.h"
#include "kudu/gutil/strings/human_readable.h"
#include "kudu/gutil/strings/substitute.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/rpc/inbound_call.cc
----------------------------------------------------------------------
diff --git a/src/kudu/rpc/inbound_call.cc b/src/kudu/rpc/inbound_call.cc
index 24ee026..8161c16 100644
--- a/src/kudu/rpc/inbound_call.cc
+++ b/src/kudu/rpc/inbound_call.cc
@@ -25,7 +25,6 @@
#include <google/protobuf/message.h>
#include <google/protobuf/message_lite.h>
-#include "kudu/gutil/move.h"
#include "kudu/gutil/port.h"
#include "kudu/gutil/strings/substitute.h"
#include "kudu/rpc/connection.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/rpc/messenger.cc
----------------------------------------------------------------------
diff --git a/src/kudu/rpc/messenger.cc b/src/kudu/rpc/messenger.cc
index 3c69512..67cd502 100644
--- a/src/kudu/rpc/messenger.cc
+++ b/src/kudu/rpc/messenger.cc
@@ -29,7 +29,6 @@
#include "kudu/gutil/gscoped_ptr.h"
#include "kudu/gutil/map-util.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/port.h"
#include "kudu/gutil/stl_util.h"
#include "kudu/gutil/strings/substitute.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/rpc/mt-rpc-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/rpc/mt-rpc-test.cc b/src/kudu/rpc/mt-rpc-test.cc
index 1841bc4..7427850 100644
--- a/src/kudu/rpc/mt-rpc-test.cc
+++ b/src/kudu/rpc/mt-rpc-test.cc
@@ -29,7 +29,6 @@
#include <gtest/gtest.h>
#include "kudu/gutil/gscoped_ptr.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/port.h"
#include "kudu/gutil/ref_counted.h"
#include "kudu/gutil/strings/substitute.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/rpc/negotiation-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/rpc/negotiation-test.cc b/src/kudu/rpc/negotiation-test.cc
index 67f93a5..976f590 100644
--- a/src/kudu/rpc/negotiation-test.cc
+++ b/src/kudu/rpc/negotiation-test.cc
@@ -50,6 +50,7 @@
#include "kudu/security/cert.h"
#include "kudu/security/crypto.h"
#include "kudu/security/security-test-util.h"
+#include "kudu/security/security_flags.h"
#include "kudu/security/test/mini_kdc.h"
#include "kudu/security/tls_context.h"
#include "kudu/security/tls_socket.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/rpc/outbound_call.cc
----------------------------------------------------------------------
diff --git a/src/kudu/rpc/outbound_call.cc b/src/kudu/rpc/outbound_call.cc
index f2de949..37d02ac 100644
--- a/src/kudu/rpc/outbound_call.cc
+++ b/src/kudu/rpc/outbound_call.cc
@@ -28,7 +28,6 @@
#include <gflags/gflags.h>
#include <google/protobuf/message.h>
-#include "kudu/gutil/move.h"
#include "kudu/gutil/port.h"
#include "kudu/gutil/stringprintf.h"
#include "kudu/gutil/strings/substitute.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/rpc/service_pool.cc
----------------------------------------------------------------------
diff --git a/src/kudu/rpc/service_pool.cc b/src/kudu/rpc/service_pool.cc
index a2d5d2d..5acb5e4 100644
--- a/src/kudu/rpc/service_pool.cc
+++ b/src/kudu/rpc/service_pool.cc
@@ -30,7 +30,6 @@
#include "kudu/gutil/basictypes.h"
#include "kudu/gutil/gscoped_ptr.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/ref_counted.h"
#include "kudu/gutil/strings/join.h"
#include "kudu/gutil/strings/substitute.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/security/tls_context.h
----------------------------------------------------------------------
diff --git a/src/kudu/security/tls_context.h b/src/kudu/security/tls_context.h
index 4a4dba1..786ab6e 100644
--- a/src/kudu/security/tls_context.h
+++ b/src/kudu/security/tls_context.h
@@ -30,12 +30,13 @@
#include "kudu/util/locks.h"
#include "kudu/util/rw_mutex.h"
#include "kudu/util/status.h"
+// IWYU pragma: no_include "kudu/security/cert.h"
namespace kudu {
namespace security {
-class Cert;
-class CertSignRequest;
+class Cert; // IWYU pragma: keep
+class CertSignRequest;// IWYU pragma: keep
class PrivateKey;
// TlsContext wraps data required by the OpenSSL library for creating and
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/server/rpc_server.cc
----------------------------------------------------------------------
diff --git a/src/kudu/server/rpc_server.cc b/src/kudu/server/rpc_server.cc
index f1fab57..fc8be32 100644
--- a/src/kudu/server/rpc_server.cc
+++ b/src/kudu/server/rpc_server.cc
@@ -29,7 +29,6 @@
#include "kudu/gutil/casts.h"
#include "kudu/gutil/gscoped_ptr.h"
#include "kudu/gutil/macros.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/ref_counted.h"
#include "kudu/gutil/strings/substitute.h"
#include "kudu/rpc/acceptor_pool.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/server/server_base.cc
----------------------------------------------------------------------
diff --git a/src/kudu/server/server_base.cc b/src/kudu/server/server_base.cc
index 9b08404..8834573 100644
--- a/src/kudu/server/server_base.cc
+++ b/src/kudu/server/server_base.cc
@@ -40,7 +40,6 @@
#include "kudu/common/wire_protocol.pb.h"
#include "kudu/fs/fs_manager.h"
#include "kudu/fs/fs_report.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/port.h"
#include "kudu/gutil/strings/strcat.h"
#include "kudu/gutil/strings/substitute.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/tablet/compaction.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/compaction.cc b/src/kudu/tablet/compaction.cc
index 981a638..afabfd3 100644
--- a/src/kudu/tablet/compaction.cc
+++ b/src/kudu/tablet/compaction.cc
@@ -42,7 +42,6 @@
#include "kudu/gutil/casts.h"
#include "kudu/gutil/macros.h"
#include "kudu/gutil/map-util.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/port.h"
#include "kudu/gutil/stl_util.h"
#include "kudu/gutil/strings/substitute.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/tablet/diskrowset-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/diskrowset-test.cc
b/src/kudu/tablet/diskrowset-test.cc
index d6e9363..d2c6867 100644
--- a/src/kudu/tablet/diskrowset-test.cc
+++ b/src/kudu/tablet/diskrowset-test.cc
@@ -38,7 +38,6 @@
#include "kudu/common/timestamp.h"
#include "kudu/fs/block_id.h"
#include "kudu/gutil/gscoped_ptr.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/ref_counted.h"
#include "kudu/gutil/stringprintf.h"
#include "kudu/gutil/strings/stringpiece.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/tablet/memrowset.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/memrowset.cc b/src/kudu/tablet/memrowset.cc
index b08228d..3c21347 100644
--- a/src/kudu/tablet/memrowset.cc
+++ b/src/kudu/tablet/memrowset.cc
@@ -38,7 +38,6 @@
#include "kudu/consensus/log_anchor_registry.h"
#include "kudu/consensus/opid.pb.h"
#include "kudu/gutil/dynamic_annotations.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/port.h"
#include "kudu/gutil/strings/substitute.h"
#include "kudu/tablet/compaction.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/tablet/row_op.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/row_op.cc b/src/kudu/tablet/row_op.cc
index e6e1330..87e94e4 100644
--- a/src/kudu/tablet/row_op.cc
+++ b/src/kudu/tablet/row_op.cc
@@ -23,7 +23,6 @@
#include <glog/logging.h>
#include "kudu/common/wire_protocol.h"
-#include "kudu/gutil/move.h"
#include "kudu/tablet/rowset.h"
#include "kudu/tablet/tablet.pb.h"
#include "kudu/util/pb_util.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/tablet/rowset.h
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/rowset.h b/src/kudu/tablet/rowset.h
index 4cc4252..89ef088 100644
--- a/src/kudu/tablet/rowset.h
+++ b/src/kudu/tablet/rowset.h
@@ -34,7 +34,6 @@
#include "kudu/common/timestamp.h"
#include "kudu/gutil/gscoped_ptr.h"
#include "kudu/gutil/macros.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/port.h"
#include "kudu/util/bloom_filter.h"
#include "kudu/util/status.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/tablet/rowset_info.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/rowset_info.cc b/src/kudu/tablet/rowset_info.cc
index 4c12780..44fbd10 100644
--- a/src/kudu/tablet/rowset_info.cc
+++ b/src/kudu/tablet/rowset_info.cc
@@ -23,7 +23,6 @@
#include <memory>
#include <ostream>
#include <string>
-#include <type_traits>
#include <unordered_map>
#include <utility>
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/tablet/svg_dump.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/svg_dump.cc b/src/kudu/tablet/svg_dump.cc
index 50f46be..1427b9b 100644
--- a/src/kudu/tablet/svg_dump.cc
+++ b/src/kudu/tablet/svg_dump.cc
@@ -29,7 +29,6 @@
#include "kudu/gutil/gscoped_ptr.h"
#include "kudu/gutil/macros.h"
#include "kudu/gutil/map-util.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/stringprintf.h"
#include "kudu/gutil/strings/util.h"
#include "kudu/tablet/rowset_info.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/tablet/tablet-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/tablet-test.cc b/src/kudu/tablet/tablet-test.cc
index 3b9c954..2af4877 100644
--- a/src/kudu/tablet/tablet-test.cc
+++ b/src/kudu/tablet/tablet-test.cc
@@ -38,7 +38,6 @@
#include "kudu/fs/block_id.h"
#include "kudu/fs/block_manager.h"
#include "kudu/gutil/gscoped_ptr.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/port.h"
#include "kudu/gutil/stl_util.h"
#include "kudu/gutil/strings/join.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/tablet/tablet.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/tablet.cc b/src/kudu/tablet/tablet.cc
index 86182ab..8e7b8b4 100644
--- a/src/kudu/tablet/tablet.cc
+++ b/src/kudu/tablet/tablet.cc
@@ -54,7 +54,6 @@
#include "kudu/gutil/bind.h"
#include "kudu/gutil/bind_helpers.h"
#include "kudu/gutil/casts.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/stl_util.h"
#include "kudu/gutil/strings/human_readable.h"
#include "kudu/gutil/strings/substitute.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/tablet/tablet_bootstrap-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/tablet_bootstrap-test.cc
b/src/kudu/tablet/tablet_bootstrap-test.cc
index e8131e0..0b80c20 100644
--- a/src/kudu/tablet/tablet_bootstrap-test.cc
+++ b/src/kudu/tablet/tablet_bootstrap-test.cc
@@ -57,7 +57,6 @@
#include "kudu/fs/data_dirs.h"
#include "kudu/fs/fs_manager.h"
#include "kudu/gutil/gscoped_ptr.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/port.h"
#include "kudu/gutil/ref_counted.h"
#include "kudu/rpc/result_tracker.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/tablet/tablet_history_gc-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/tablet_history_gc-test.cc
b/src/kudu/tablet/tablet_history_gc-test.cc
index 7aec88a..729a4ba 100644
--- a/src/kudu/tablet/tablet_history_gc-test.cc
+++ b/src/kudu/tablet/tablet_history_gc-test.cc
@@ -38,7 +38,6 @@
#include "kudu/common/schema.h"
#include "kudu/common/timestamp.h"
#include "kudu/gutil/casts.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/port.h"
#include "kudu/gutil/ref_counted.h"
#include "kudu/gutil/strings/substitute.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/tablet/tablet_metadata.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/tablet_metadata.cc
b/src/kudu/tablet/tablet_metadata.cc
index c8c04a7..7c536f7 100644
--- a/src/kudu/tablet/tablet_metadata.cc
+++ b/src/kudu/tablet/tablet_metadata.cc
@@ -38,7 +38,6 @@
#include "kudu/gutil/atomicops.h"
#include "kudu/gutil/bind.h"
#include "kudu/gutil/map-util.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/port.h"
#include "kudu/gutil/stl_util.h"
#include "kudu/gutil/strings/substitute.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/tablet/tablet_metadata.h
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/tablet_metadata.h
b/src/kudu/tablet/tablet_metadata.h
index 107ec9f..64b59e8 100644
--- a/src/kudu/tablet/tablet_metadata.h
+++ b/src/kudu/tablet/tablet_metadata.h
@@ -29,7 +29,7 @@
#include "kudu/common/partition.h"
#include "kudu/fs/block_id.h"
#include "kudu/gutil/atomicops.h"
-#include "kudu/gutil/callback.h"
+#include "kudu/gutil/callback.h" // IWYU pragma: keep
#include "kudu/gutil/gscoped_ptr.h"
#include "kudu/gutil/macros.h"
#include "kudu/gutil/ref_counted.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/tablet/tablet_replica-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/tablet_replica-test.cc
b/src/kudu/tablet/tablet_replica-test.cc
index bab0972..8508dd5 100644
--- a/src/kudu/tablet/tablet_replica-test.cc
+++ b/src/kudu/tablet/tablet_replica-test.cc
@@ -49,7 +49,6 @@
#include "kudu/gutil/bind_helpers.h"
#include "kudu/gutil/gscoped_ptr.h"
#include "kudu/gutil/macros.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/port.h"
#include "kudu/gutil/ref_counted.h"
#include "kudu/rpc/messenger.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/tablet/tablet_replica.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/tablet_replica.cc
b/src/kudu/tablet/tablet_replica.cc
index 72ad7ec..821cd29 100644
--- a/src/kudu/tablet/tablet_replica.cc
+++ b/src/kudu/tablet/tablet_replica.cc
@@ -39,7 +39,6 @@
#include "kudu/consensus/raft_consensus.h"
#include "kudu/gutil/bind.h"
#include "kudu/gutil/bind_helpers.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/stl_util.h"
#include "kudu/gutil/strings/substitute.h"
#include "kudu/rpc/result_tracker.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/tablet/transactions/transaction_driver.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/transactions/transaction_driver.cc
b/src/kudu/tablet/transactions/transaction_driver.cc
index 6068487..7dfb28a 100644
--- a/src/kudu/tablet/transactions/transaction_driver.cc
+++ b/src/kudu/tablet/transactions/transaction_driver.cc
@@ -36,7 +36,6 @@
#include "kudu/consensus/time_manager.h"
#include "kudu/gutil/bind.h"
#include "kudu/gutil/bind_helpers.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/port.h"
#include "kudu/gutil/strings/strcat.h"
#include "kudu/gutil/strings/substitute.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/tablet/transactions/transaction_tracker-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/transactions/transaction_tracker-test.cc
b/src/kudu/tablet/transactions/transaction_tracker-test.cc
index 2929e38..dbd4e07 100644
--- a/src/kudu/tablet/transactions/transaction_tracker-test.cc
+++ b/src/kudu/tablet/transactions/transaction_tracker-test.cc
@@ -29,7 +29,6 @@
#include "kudu/consensus/consensus.pb.h"
#include "kudu/gutil/casts.h"
#include "kudu/gutil/gscoped_ptr.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/port.h"
#include "kudu/gutil/ref_counted.h"
#include "kudu/tablet/transactions/transaction.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/tablet/transactions/write_transaction.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/transactions/write_transaction.cc
b/src/kudu/tablet/transactions/write_transaction.cc
index c32f506..47fc57b 100644
--- a/src/kudu/tablet/transactions/write_transaction.cc
+++ b/src/kudu/tablet/transactions/write_transaction.cc
@@ -39,7 +39,6 @@
#include "kudu/consensus/raft_consensus.h"
#include "kudu/util/memory/arena.h"
#include "kudu/gutil/dynamic_annotations.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/strings/substitute.h"
#include "kudu/gutil/walltime.h"
#include "kudu/rpc/rpc_header.pb.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/tools/ksck_remote.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tools/ksck_remote.cc b/src/kudu/tools/ksck_remote.cc
index a38d579..d24f8c7 100644
--- a/src/kudu/tools/ksck_remote.cc
+++ b/src/kudu/tools/ksck_remote.cc
@@ -18,6 +18,8 @@
#include "kudu/tools/ksck_remote.h"
#include <cstdint>
+#include <ostream>
+#include <unordered_map>
#include <boost/bind.hpp> // IWYU pragma: keep
#include <boost/optional/optional.hpp>
@@ -26,6 +28,7 @@
#include <glog/logging.h>
#include "kudu/client/client.h"
+#include "kudu/client/schema.h"
#include "kudu/client/replica_controller-internal.h"
#include "kudu/common/common.pb.h"
#include "kudu/common/schema.h"
@@ -33,6 +36,10 @@
#include "kudu/common/wire_protocol.pb.h"
#include "kudu/consensus/consensus.pb.h"
#include "kudu/consensus/consensus.proxy.h"
+#include "kudu/consensus/metadata.pb.h"
+#include "kudu/gutil/basictypes.h"
+#include "kudu/gutil/gscoped_ptr.h"
+#include "kudu/gutil/map-util.h"
#include "kudu/gutil/stl_util.h"
#include "kudu/gutil/strings/substitute.h"
#include "kudu/master/master.h"
@@ -42,13 +49,14 @@
#include "kudu/rpc/rpc_controller.h"
#include "kudu/server/server_base.pb.h"
#include "kudu/server/server_base.proxy.h"
+#include "kudu/tablet/tablet.pb.h"
#include "kudu/tserver/tablet_server.h"
#include "kudu/tserver/tserver.pb.h"
#include "kudu/tserver/tserver_service.pb.h"
#include "kudu/tserver/tserver_service.proxy.h"
#include "kudu/util/monotime.h"
#include "kudu/util/net/net_util.h"
-#include "kudu/util/slice.h"
+#include "kudu/util/net/sockaddr.h"
DECLARE_int64(timeout_ms); // defined in tool_action_common
DEFINE_bool(checksum_cache_blocks, false, "Should the checksum scanners cache
the read blocks");
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/tools/tool_action_remote_replica.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tools/tool_action_remote_replica.cc
b/src/kudu/tools/tool_action_remote_replica.cc
index e910783..d427224 100644
--- a/src/kudu/tools/tool_action_remote_replica.cc
+++ b/src/kudu/tools/tool_action_remote_replica.cc
@@ -45,7 +45,6 @@
#include "kudu/consensus/metadata.pb.h"
#include "kudu/gutil/gscoped_ptr.h"
#include "kudu/gutil/map-util.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/strings/human_readable.h"
#include "kudu/gutil/strings/substitute.h"
#include "kudu/rpc/rpc_controller.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/tserver/tablet_copy_source_session-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tserver/tablet_copy_source_session-test.cc
b/src/kudu/tserver/tablet_copy_source_session-test.cc
index 2447805..66dc9a6 100644
--- a/src/kudu/tserver/tablet_copy_source_session-test.cc
+++ b/src/kudu/tserver/tablet_copy_source_session-test.cc
@@ -46,7 +46,6 @@
#include "kudu/gutil/bind.h"
#include "kudu/gutil/bind_helpers.h"
#include "kudu/gutil/gscoped_ptr.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/ref_counted.h"
#include "kudu/gutil/strings/fastmem.h"
#include "kudu/gutil/strings/substitute.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/tserver/tablet_server.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tserver/tablet_server.cc
b/src/kudu/tserver/tablet_server.cc
index efbbe03..068408b 100644
--- a/src/kudu/tserver/tablet_server.cc
+++ b/src/kudu/tserver/tablet_server.cc
@@ -29,7 +29,6 @@
#include "kudu/fs/fs_manager.h"
#include "kudu/gutil/bind.h"
#include "kudu/gutil/bind_helpers.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/strings/substitute.h"
#include "kudu/rpc/service_if.h"
#include "kudu/tserver/heartbeater.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/tserver/tablet_service.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tserver/tablet_service.cc
b/src/kudu/tserver/tablet_service.cc
index 2f4d285..bf2be2b 100644
--- a/src/kudu/tserver/tablet_service.cc
+++ b/src/kudu/tserver/tablet_service.cc
@@ -57,7 +57,6 @@
#include "kudu/gutil/casts.h"
#include "kudu/gutil/macros.h"
#include "kudu/gutil/map-util.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/ref_counted.h"
#include "kudu/gutil/stringprintf.h"
#include "kudu/gutil/strings/substitute.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/util/callback_bind-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/util/callback_bind-test.cc
b/src/kudu/util/callback_bind-test.cc
index db4d079..392f496 100644
--- a/src/kudu/util/callback_bind-test.cc
+++ b/src/kudu/util/callback_bind-test.cc
@@ -28,7 +28,6 @@
#include "kudu/gutil/callback.h"
#include "kudu/gutil/gscoped_ptr.h"
#include "kudu/gutil/macros.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/ref_counted.h"
namespace kudu {
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/util/debug/trace_event_impl.cc
----------------------------------------------------------------------
diff --git a/src/kudu/util/debug/trace_event_impl.cc
b/src/kudu/util/debug/trace_event_impl.cc
index 765ce84..ca1862d 100644
--- a/src/kudu/util/debug/trace_event_impl.cc
+++ b/src/kudu/util/debug/trace_event_impl.cc
@@ -24,7 +24,6 @@
#include "kudu/gutil/dynamic_annotations.h"
#include "kudu/gutil/map-util.h"
#include "kudu/gutil/mathlimits.h"
-#include "kudu/gutil/move.h"
#include "kudu/gutil/port.h"
#include "kudu/gutil/ref_counted_memory.h"
#include "kudu/gutil/singleton.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/util/env.h
----------------------------------------------------------------------
diff --git a/src/kudu/util/env.h b/src/kudu/util/env.h
index 3e5981b..2822994 100644
--- a/src/kudu/util/env.h
+++ b/src/kudu/util/env.h
@@ -15,6 +15,7 @@
#include <cstddef>
#include <cstdint>
+#include <iosfwd>
#include <map>
#include <memory>
#include <string>
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/util/object_pool-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/util/object_pool-test.cc
b/src/kudu/util/object_pool-test.cc
index 954b834..ecfd641 100644
--- a/src/kudu/util/object_pool-test.cc
+++ b/src/kudu/util/object_pool-test.cc
@@ -18,7 +18,6 @@
#include <gtest/gtest.h>
#include "kudu/gutil/gscoped_ptr.h"
-#include "kudu/gutil/move.h"
#include "kudu/util/object_pool.h"
namespace kudu {
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/util/once.h
----------------------------------------------------------------------
diff --git a/src/kudu/util/once.h b/src/kudu/util/once.h
index 522d800..0f43064 100644
--- a/src/kudu/util/once.h
+++ b/src/kudu/util/once.h
@@ -20,6 +20,7 @@
#include <stddef.h>
#include "kudu/gutil/once.h"
+#include "kudu/gutil/port.h"
#include "kudu/util/atomic.h"
#include "kudu/util/status.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/767005c5/src/kudu/util/trace_metrics.h
----------------------------------------------------------------------
diff --git a/src/kudu/util/trace_metrics.h b/src/kudu/util/trace_metrics.h
index 58a26ef..8c460bd 100644
--- a/src/kudu/util/trace_metrics.h
+++ b/src/kudu/util/trace_metrics.h
@@ -23,7 +23,6 @@
#include "kudu/gutil/macros.h"
#include "kudu/gutil/map-util.h"
-#include "kudu/util/atomic.h"
#include "kudu/util/locks.h"
namespace kudu {
