(kudu) 01/02: [net] remove unused Socket::GetSockError() method

[abukor]

This is an automated email from the ASF dual-hosted git repository.

abukor pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit 14d95ca04c46cdcd21b969a3297056e63ecd8611
Author: Alexey Serbin <ale...@apache.org>
AuthorDate: Thu Jan 11 14:26:31 2024 -0800

    [net] remove unused Socket::GetSockError() method
    
    Change-Id: I74590637c08f303280b05eea9c9d7860918e054c
    Reviewed-on: http://gerrit.cloudera.org:8080/20888
    Reviewed-by: Abhishek Chennaka <achenn...@cloudera.com>
    Tested-by: Alexey Serbin <ale...@apache.org>
---
 src/kudu/util/net/socket.cc | 15 ---------------
 src/kudu/util/net/socket.h  |  3 ---
 2 files changed, 18 deletions(-)

diff --git a/src/kudu/util/net/socket.cc b/src/kudu/util/net/socket.cc
index 75ff53544..f68b4e635 100644
--- a/src/kudu/util/net/socket.cc
+++ b/src/kudu/util/net/socket.cc
@@ -562,21 +562,6 @@ Status Socket::Connect(const Sockaddr& remote) {
   return Status::OK();
 }
 
-Status Socket::GetSockError() const {
-  int val = 0, ret;
-  socklen_t val_len = sizeof(val);
-  DCHECK_GE(fd_, 0);
-  ret = ::getsockopt(fd_, SOL_SOCKET, SO_ERROR, &val, &val_len);
-  if (ret) {
-    int err = errno;
-    return Status::NetworkError("getsockopt(SO_ERROR) failed", 
ErrnoToString(err), err);
-  }
-  if (val != 0) {
-    return Status::NetworkError(ErrnoToString(val), Slice(), val);
-  }
-  return Status::OK();
-}
-
 Status Socket::Write(const uint8_t* buf, int32_t amt, int32_t* nwritten) {
   if (amt <= 0) {
     return Status::NetworkError(
diff --git a/src/kudu/util/net/socket.h b/src/kudu/util/net/socket.h
index a301ebafd..10125eb97 100644
--- a/src/kudu/util/net/socket.h
+++ b/src/kudu/util/net/socket.h
@@ -126,9 +126,6 @@ class Socket {
   // start connecting this socket to a remote address.
   Status Connect(const Sockaddr& remote);
 
-  // get the error status using getsockopt(2)
-  Status GetSockError() const;
-
   // Write up to 'amt' bytes from 'buf' to the socket. The number of bytes
   // actually written will be stored in 'nwritten'. If an error is returned,
   // the value of 'nwritten' is undefined.