This is an automated email from the ASF dual-hosted git repository.
alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
commit d980c688db3b86bd248723d23dc093c668307211
Author: Alexey Serbin <ale...@apache.org>
AuthorDate: Wed Mar 27 16:45:23 2024 -0700
[rpc] relax settings for MeasureAcceptorDispatchTimes
On some nodes, RpcAcceptorBench.MeasureAcceptorDispatchTimes might
run out of file descriptors if run with 16 concurrent client threads,
failing the test. This patch modifies the default settings for the
scenario to run with just a single client thread by default. That's
enough to provide good coverage for the related metrics while easing
the load on a test node.
Change-Id: Ic9af59046d6bcf28134cc88e7ff9e54643efc37f
Reviewed-on: http://gerrit.cloudera.org:8080/21212
Reviewed-by: Mahesh Reddy <mre...@cloudera.com>
Reviewed-by: Abhishek Chennaka <achenn...@cloudera.com>
Tested-by: Alexey Serbin <ale...@apache.org>
---
src/kudu/rpc/rpc-bench.cc | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/src/kudu/rpc/rpc-bench.cc b/src/kudu/rpc/rpc-bench.cc
index 6b0d4bfd5..ca42fd8ef 100644
--- a/src/kudu/rpc/rpc-bench.cc
+++ b/src/kudu/rpc/rpc-bench.cc
@@ -337,6 +337,15 @@ class RpcAcceptorBench : public RpcTestBase {
};
TEST_F(RpcAcceptorBench, MeasureAcceptorDispatchTimes) {
+ // It's enough to have just one client thread to verify that the acceptor
+ // dispatch times metric works as expected, so let's set this minimum viable
+ // configuration as the default one. The option of changing the default
+ // setting for --client_threads for all the test scenarios in this file
+ // doesn't look attractive since other scenarios rely on client-side
+ // concurrency to provide some meaningful test coverage.
+ ASSERT_NE("", SetCommandLineOptionWithMode("client_threads",
+ "1",
+ gflags::SET_FLAGS_DEFAULT));
const size_t threads_num = FLAGS_client_threads;
thread threads[threads_num];
