This is an automated email from the ASF dual-hosted git repository.
alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
commit 7b5fc9f2f0ad538242656431bf76e253cc537772
Author: Marton Greber <greber...@gmail.com>
AuthorDate: Thu Apr 18 11:13:30 2024 +0200
Update build pattern for fetching flaky tests list
During the infra changes which happened in the last months, the build_id
prefix has been changed [note 1]. As a result flaky tests are not
retried during testing in the pre-commit runs. This patch updates the
build pattern in the build-and-test.sh script, such that the
list of flaky tests is fetched correctly.
[note 1]:
The build_id of an isolated test is constructed with Jenkins job's name
and build number, prefixed with "jenkins-". To illustrate this let me
give some examples, for build_ids prior and after the infra upgrade.
Before:
jenkins-kudu-gerrit-BUILD_TYPE=ASAN-29232
jenkins-kudu-gerrit-BUILD_TYPE=DEBUG-29227
After:
jenkins-build_and_test-64
jenkins-build_and_test-63
From the above we can see that the new Jenkins job name caused the
issue. The new job is parametrised, does not contain the build type in
the job's name. Therefore, a change in the naming is justified.
In case something like this happens in the future, the build_ids can be
observed in the test_results MySQL database on the isolateserver test
infra host.
Change-Id: I317a3a32c06c06306b97566f954e0ffd508ce01f
Reviewed-on: http://gerrit.cloudera.org:8080/21327
Reviewed-by: Ashwani Raina <ara...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <ale...@apache.org>
---
build-support/jenkins/build-and-test.sh | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/build-support/jenkins/build-and-test.sh
b/build-support/jenkins/build-and-test.sh
index 8f6d8c74e..6801f9e42 100755
--- a/build-support/jenkins/build-and-test.sh
+++ b/build-support/jenkins/build-and-test.sh
@@ -39,8 +39,8 @@
#
# KUDU_FLAKY_TEST_ATTEMPTS Default: 1
# If more than 1, will fetch the list of known flaky tests
-# from the kudu-test jenkins job, and allow those tests to
-# be flaky in this build.
+# from the jenkins jobs matching the "%jenkins-%" pattern, and allow those
+# tests to be flaky in this build.
#
# TEST_RESULT_SERVER Default: none
# The host:port pair of a server running test_result_server.py.
@@ -183,8 +183,11 @@ mkdir -p $BUILD_ROOT
# Same for the Java tests, which aren't inside BUILD_ROOT
rm -rf $SOURCE_ROOT/java/*/build
+# The build_pattern is %jenkins-% because we are interested in two types of
runs:
+# 1. As of now build_and_test pipeline job which is triggered by the
pre-commit pipeline job.
+# 2. Any other job which is used to run the flaky tests only.
list_flaky_tests() {
- local
url="http://$TEST_RESULT_SERVER/list_failed_tests?num_days=3&build_pattern=%25kudu-test%25";
+ local
url="http://$TEST_RESULT_SERVER/list_failed_tests?num_days=3&build_pattern=%25jenkins-%25";
>&2 echo Fetching flaky test list from "$url" ...
curl -s --show-error "$url"
return $?
