(kvrocks) branch unstable updated: fix(core): remove extraneous RocksDB::CancelAllBackgroundWork calls (#3017) (#3019)

[hulk]

This is an automated email from the ASF dual-hosted git repository.

hulk pushed a commit to branch unstable
in repository https://gitbox.apache.org/repos/asf/kvrocks.git


The following commit(s) were added to refs/heads/unstable by this push:
     new 8a50e51c5 fix(core): remove extraneous 
RocksDB::CancelAllBackgroundWork calls (#3017) (#3019)
8a50e51c5 is described below

commit 8a50e51c514ef6456ea45252c05b5491378eaa65
Author: Ryan Liao <71594512+ryan4...@users.noreply.github.com>
AuthorDate: Tue Jun 10 01:30:13 2025 -0400

    fix(core): remove extraneous RocksDB::CancelAllBackgroundWork calls (#3017) 
(#3019)
    
    Co-authored-by: hulk <hulk.webs...@gmail.com>
---
 src/server/server.cc   | 1 -
 src/storage/storage.cc | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/server/server.cc b/src/server/server.cc
index 0d62f98a2..8755f4f30 100644
--- a/src/server/server.cc
+++ b/src/server/server.cc
@@ -256,7 +256,6 @@ void Server::Stop() {
     worker->Stop(0 /* immediately terminate  */);
   }
 
-  rocksdb::CancelAllBackgroundWork(storage->GetDB(), true);
   task_runner_.Cancel();
 }
 
diff --git a/src/storage/storage.cc b/src/storage/storage.cc
index 8681eed87..70e7008da 100644
--- a/src/storage/storage.cc
+++ b/src/storage/storage.cc
@@ -102,8 +102,8 @@ void Storage::CloseDB() {
 
   db_closing_ = true;
   db_->SyncWAL();
-  rocksdb::CancelAllBackgroundWork(db_.get(), true);
   for (auto handle : cf_handles_) db_->DestroyColumnFamilyHandle(handle);
+  db_->Close();
   db_ = nullptr;
 }