KYLIN-1160 code review
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/55c448b3 Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/55c448b3 Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/55c448b3 Branch: refs/heads/1.x-HBase1.1.3 Commit: 55c448b30907eefca3561b8c15c61baccc4fba66 Parents: b7b6793 Author: Li, Yang <yang...@ebay.com> Authored: Wed Nov 25 15:39:39 2015 +0800 Committer: Li, Yang <yang...@ebay.com> Committed: Wed Nov 25 15:39:39 2015 +0800 ---------------------------------------------------------------------- .../main/java/org/apache/kylin/common/util/Log4jConfigurer.java | 4 ++-- .../main/java/org/apache/kylin/jdbc/util/Log4jConfigurer.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kylin/blob/55c448b3/common/src/main/java/org/apache/kylin/common/util/Log4jConfigurer.java ---------------------------------------------------------------------- diff --git a/common/src/main/java/org/apache/kylin/common/util/Log4jConfigurer.java b/common/src/main/java/org/apache/kylin/common/util/Log4jConfigurer.java index c329ced..6f887b7 100644 --- a/common/src/main/java/org/apache/kylin/common/util/Log4jConfigurer.java +++ b/common/src/main/java/org/apache/kylin/common/util/Log4jConfigurer.java @@ -17,15 +17,15 @@ public class Log4jConfigurer { public static void initLogger() { if (!INITIALIZED && !isConfigured()) { org.apache.log4j.BasicConfigurator.configure(new ConsoleAppender(new PatternLayout(DEFAULT_PATTERN_LAYOUT))); - INITIALIZED = true; } + INITIALIZED = true; } private static boolean isConfigured() { if (LogManager.getRootLogger().getAllAppenders().hasMoreElements()) { return true; } else { - Enumeration loggers = LogManager.getCurrentLoggers(); + Enumeration<?> loggers = LogManager.getCurrentLoggers(); while (loggers.hasMoreElements()) { Logger logger = (Logger) loggers.nextElement(); if (logger.getAllAppenders().hasMoreElements()) http://git-wip-us.apache.org/repos/asf/kylin/blob/55c448b3/jdbc/src/main/java/org/apache/kylin/jdbc/util/Log4jConfigurer.java ---------------------------------------------------------------------- diff --git a/jdbc/src/main/java/org/apache/kylin/jdbc/util/Log4jConfigurer.java b/jdbc/src/main/java/org/apache/kylin/jdbc/util/Log4jConfigurer.java index 715d190..8bf35e2 100644 --- a/jdbc/src/main/java/org/apache/kylin/jdbc/util/Log4jConfigurer.java +++ b/jdbc/src/main/java/org/apache/kylin/jdbc/util/Log4jConfigurer.java @@ -17,15 +17,15 @@ public class Log4jConfigurer { public static void initLogger() { if (!INITIALIZED && !isConfigured()) { org.apache.log4j.BasicConfigurator.configure(new ConsoleAppender(new PatternLayout(DEFAULT_PATTERN_LAYOUT))); - INITIALIZED = true; } + INITIALIZED = true; } private static boolean isConfigured() { if (LogManager.getRootLogger().getAllAppenders().hasMoreElements()) { return true; } else { - Enumeration loggers = LogManager.getCurrentLoggers(); + Enumeration<?> loggers = LogManager.getCurrentLoggers(); while (loggers.hasMoreElements()) { Logger logger = (Logger) loggers.nextElement(); if (logger.getAllAppenders().hasMoreElements())