Repository: kylin
Updated Branches:
  refs/heads/master 28d90ec07 -> ca269c99c


fix CI


Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/ca269c99
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/ca269c99
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/ca269c99

Branch: refs/heads/master
Commit: ca269c99c2e84bfb2eca77821052689acbb9ac64
Parents: 28d90ec
Author: Li Yang <liy...@apache.org>
Authored: Wed Mar 30 13:16:14 2016 +0800
Committer: Li Yang <liy...@apache.org>
Committed: Wed Mar 30 13:16:47 2016 +0800

----------------------------------------------------------------------
 .../apache/kylin/cube/model/validation/rule/RowKeyAttrRule.java | 5 -----
 1 file changed, 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kylin/blob/ca269c99/core-cube/src/main/java/org/apache/kylin/cube/model/validation/rule/RowKeyAttrRule.java
----------------------------------------------------------------------
diff --git 
a/core-cube/src/main/java/org/apache/kylin/cube/model/validation/rule/RowKeyAttrRule.java
 
b/core-cube/src/main/java/org/apache/kylin/cube/model/validation/rule/RowKeyAttrRule.java
index 932754c..13138ba 100644
--- 
a/core-cube/src/main/java/org/apache/kylin/cube/model/validation/rule/RowKeyAttrRule.java
+++ 
b/core-cube/src/main/java/org/apache/kylin/cube/model/validation/rule/RowKeyAttrRule.java
@@ -26,7 +26,6 @@ import org.apache.kylin.cube.model.validation.ResultLevel;
 import org.apache.kylin.cube.model.validation.ValidateContext;
 
 /**
- * Validate that only one of "length" and "dictionary" appears on rowkey_column
  */
 public class RowKeyAttrRule implements IValidatorRule<CubeDesc> {
 
@@ -48,10 +47,6 @@ public class RowKeyAttrRule implements 
IValidatorRule<CubeDesc> {
             RowKeyColDesc rd = rcd[i];
             if (rd.getColumn() == null || rd.getColumn().length() == 0) {
                 context.addResult(ResultLevel.ERROR, "Rowkey column empty");
-                continue;
-            }
-            if (!rd.getEncoding().equalsIgnoreCase("dict") && 
!rd.getEncoding().toLowerCase().startsWith("fixed_length")) {
-                context.addResult(ResultLevel.ERROR, "Rowkey column " + 
rd.getColumn() + " encoding not dict nor fixed_length");
             }
         }
 

Reply via email to