minor, add one more test case
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/1df35ab8 Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/1df35ab8 Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/1df35ab8 Branch: refs/heads/1.5.4-rc1 Commit: 1df35ab852c21e8dc6c90f82d343a5432661db06 Parents: 6ddf4b5 Author: Hongbin Ma <mahong...@apache.org> Authored: Thu Sep 8 11:18:52 2016 +0800 Committer: Hongbin Ma <mahong...@apache.org> Committed: Fri Sep 9 18:52:49 2016 +0800 ---------------------------------------------------------------------- .../org/apache/kylin/cube/CubeCapabilityChecker.java | 7 ++++++- kylin-it/src/test/resources/query/sql_like/query18.sql | 13 +++++++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kylin/blob/1df35ab8/core-cube/src/main/java/org/apache/kylin/cube/CubeCapabilityChecker.java ---------------------------------------------------------------------- diff --git a/core-cube/src/main/java/org/apache/kylin/cube/CubeCapabilityChecker.java b/core-cube/src/main/java/org/apache/kylin/cube/CubeCapabilityChecker.java index 79d1e3b..e8c96b4 100644 --- a/core-cube/src/main/java/org/apache/kylin/cube/CubeCapabilityChecker.java +++ b/core-cube/src/main/java/org/apache/kylin/cube/CubeCapabilityChecker.java @@ -31,6 +31,7 @@ import org.apache.kylin.metadata.filter.UDF.MassInTupleFilter; import org.apache.kylin.metadata.model.FunctionDesc; import org.apache.kylin.metadata.model.IStorageAware; import org.apache.kylin.metadata.model.MeasureDesc; +import org.apache.kylin.metadata.model.ParameterDesc; import org.apache.kylin.metadata.model.TblColRef; import org.apache.kylin.metadata.realization.CapabilityResult; import org.apache.kylin.metadata.realization.SQLDigest; @@ -146,7 +147,11 @@ public class CubeCapabilityChecker { } // calcite can do aggregation from columns on-the-fly - List<TblColRef> neededCols = functionDesc.getParameter().getColRefs(); + ParameterDesc parameterDesc = functionDesc.getParameter(); + if (parameterDesc == null) { + continue; + } + List<TblColRef> neededCols = parameterDesc.getColRefs(); if (neededCols.size() > 0 && cubeDesc.listDimensionColumnsIncludingDerived().containsAll(neededCols) && FunctionDesc.BUILT_IN_AGGREGATIONS.contains(functionDesc.getExpression())) { result.influences.add(new CapabilityResult.DimensionAsMeasure(functionDesc)); it.remove(); http://git-wip-us.apache.org/repos/asf/kylin/blob/1df35ab8/kylin-it/src/test/resources/query/sql_like/query18.sql ---------------------------------------------------------------------- diff --git a/kylin-it/src/test/resources/query/sql_like/query18.sql b/kylin-it/src/test/resources/query/sql_like/query18.sql new file mode 100644 index 0000000..8ef6ad4 --- /dev/null +++ b/kylin-it/src/test/resources/query/sql_like/query18.sql @@ -0,0 +1,13 @@ + +select USER_DEFINED_FIELD3 as abc + + from test_kylin_fact +inner JOIN edw.test_cal_dt as test_cal_dt + ON test_kylin_fact.cal_dt = test_cal_dt.cal_dt + inner JOIN test_category_groupings + ON test_kylin_fact.leaf_categ_id = test_category_groupings.leaf_categ_id AND test_kylin_fact.lstg_site_id = test_category_groupings.site_id + inner JOIN edw.test_sites as test_sites + ON test_kylin_fact.lstg_site_id = test_sites.site_id + + +where upper(USER_DEFINED_FIELD3) like '%VID%'
