minor, invoke toString of translated filter may be expensive
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/7aabe4cb Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/7aabe4cb Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/7aabe4cb Branch: refs/heads/sparkcubing-rebase Commit: 7aabe4cb1d1480f99b4724b20598ba216f44586a Parents: 9898a07 Author: gaodayue <gaoda...@meituan.com> Authored: Wed Dec 28 12:20:51 2016 +0800 Committer: gaodayue <gaoda...@meituan.com> Committed: Wed Dec 28 12:20:51 2016 +0800 ---------------------------------------------------------------------- .../java/org/apache/kylin/dict/BuiltInFunctionTransformer.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kylin/blob/7aabe4cb/core-dictionary/src/main/java/org/apache/kylin/dict/BuiltInFunctionTransformer.java ---------------------------------------------------------------------- diff --git a/core-dictionary/src/main/java/org/apache/kylin/dict/BuiltInFunctionTransformer.java b/core-dictionary/src/main/java/org/apache/kylin/dict/BuiltInFunctionTransformer.java index f451c2c..6ef2f96 100755 --- a/core-dictionary/src/main/java/org/apache/kylin/dict/BuiltInFunctionTransformer.java +++ b/core-dictionary/src/main/java/org/apache/kylin/dict/BuiltInFunctionTransformer.java @@ -57,13 +57,13 @@ public class BuiltInFunctionTransformer implements ITupleFilterTransformer { //normal case translated = translateCompareTupleFilter((CompareTupleFilter) tupleFilter); if (translated != null) { - logger.info("Translated {" + tupleFilter + "} to IN clause: {" + translated + "}"); + logger.debug("Translated {{}} to IN clause: {{}}", tupleFilter, translated); } } else if (tupleFilter instanceof BuiltInFunctionTupleFilter) { //like case translated = translateFunctionTupleFilter((BuiltInFunctionTupleFilter) tupleFilter); if (translated != null) { - logger.info("Translated {" + tupleFilter + "} to IN clause: {" + translated + "}"); + logger.debug("Translated {{}} to IN clause: {{}}", tupleFilter, translated); } } else if (tupleFilter instanceof LogicalTupleFilter) { @SuppressWarnings("unchecked")
