Repository: kylin Updated Branches: refs/heads/fix-sonar 37f511d47 -> 3f374d106
fix wrong FileSystem.close Project: http://git-wip-us.apache.org/repos/asf/kylin/repo Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/3f374d10 Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/3f374d10 Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/3f374d10 Branch: refs/heads/fix-sonar Commit: 3f374d10649b093442c430815e5a821b568837a1 Parents: 37f511d Author: Billy Liu <billy...@apache.org> Authored: Fri Dec 30 14:29:19 2016 +0800 Committer: Billy Liu <billy...@apache.org> Committed: Fri Dec 30 14:29:19 2016 +0800 ---------------------------------------------------------------------- .../main/java/org/apache/kylin/engine/mr/DFSFileTableReader.java | 1 - .../apache/kylin/engine/mr/steps/FactDistinctColumnsReducer.java | 1 - 2 files changed, 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kylin/blob/3f374d10/engine-mr/src/main/java/org/apache/kylin/engine/mr/DFSFileTableReader.java ---------------------------------------------------------------------- diff --git a/engine-mr/src/main/java/org/apache/kylin/engine/mr/DFSFileTableReader.java b/engine-mr/src/main/java/org/apache/kylin/engine/mr/DFSFileTableReader.java index da4a9aa..847f4bf 100644 --- a/engine-mr/src/main/java/org/apache/kylin/engine/mr/DFSFileTableReader.java +++ b/engine-mr/src/main/java/org/apache/kylin/engine/mr/DFSFileTableReader.java @@ -85,7 +85,6 @@ public class DFSFileTableReader implements TableReader { FileStatus[] listStatus = fs.listStatus(new Path(filePath)); allFiles.addAll(Arrays.asList(listStatus)); } - fs.close(); try { for (FileStatus f : allFiles) { http://git-wip-us.apache.org/repos/asf/kylin/blob/3f374d10/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/FactDistinctColumnsReducer.java ---------------------------------------------------------------------- diff --git a/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/FactDistinctColumnsReducer.java b/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/FactDistinctColumnsReducer.java index 68a35b6..a5a2d23 100644 --- a/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/FactDistinctColumnsReducer.java +++ b/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/FactDistinctColumnsReducer.java @@ -277,7 +277,6 @@ public class FactDistinctColumnsReducer extends KylinReducer<SelfDefineSortableK fs.mkdirs(outputPath); } FSDataOutputStream out = fs.create(outputFile); - fs.close(); return out; }
