KYLIN-3105, remove Interface#Scheduler's stop method.
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/d7ebaec5 Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/d7ebaec5 Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/d7ebaec5 Branch: refs/heads/master Commit: d7ebaec5162d8714ba8c2b86249d4b83cef5fdbe Parents: 9c85654 Author: tttMelody <245915...@qq.com> Authored: Thu Dec 14 16:44:05 2017 +0800 Committer: Jiatao Tao <245915...@qq.com> Committed: Thu Dec 14 19:51:54 2017 +0800 ---------------------------------------------------------------------- .../src/main/java/org/apache/kylin/job/Scheduler.java | 2 -- .../kylin/job/impl/threadpool/DefaultScheduler.java | 10 ---------- .../kylin/job/impl/threadpool/DistributedScheduler.java | 10 ---------- .../apache/kylin/job/impl/threadpool/NoopScheduler.java | 5 ----- 4 files changed, 27 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kylin/blob/d7ebaec5/core-job/src/main/java/org/apache/kylin/job/Scheduler.java ---------------------------------------------------------------------- diff --git a/core-job/src/main/java/org/apache/kylin/job/Scheduler.java b/core-job/src/main/java/org/apache/kylin/job/Scheduler.java index 93d2510..08ec771 100644 --- a/core-job/src/main/java/org/apache/kylin/job/Scheduler.java +++ b/core-job/src/main/java/org/apache/kylin/job/Scheduler.java @@ -31,8 +31,6 @@ public interface Scheduler<T extends Executable> { void shutdown() throws SchedulerException; - boolean stop(T executable) throws SchedulerException; - boolean hasStarted(); } http://git-wip-us.apache.org/repos/asf/kylin/blob/d7ebaec5/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java ---------------------------------------------------------------------- diff --git a/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java b/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java index 327a793..78f10bf 100644 --- a/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java +++ b/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java @@ -249,16 +249,6 @@ public class DefaultScheduler implements Scheduler<AbstractExecutable>, Connecti } @Override - public boolean stop(AbstractExecutable executable) throws SchedulerException { - if (hasStarted) { - return true; - } else { - //TODO should try to stop this executable - return true; - } - } - - @Override public boolean hasStarted() { return this.hasStarted; } http://git-wip-us.apache.org/repos/asf/kylin/blob/d7ebaec5/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DistributedScheduler.java ---------------------------------------------------------------------- diff --git a/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DistributedScheduler.java b/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DistributedScheduler.java index 2c934d0..055de4d 100644 --- a/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DistributedScheduler.java +++ b/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DistributedScheduler.java @@ -340,16 +340,6 @@ public class DistributedScheduler implements Scheduler<AbstractExecutable>, Conn } @Override - public boolean stop(AbstractExecutable executable) throws SchedulerException { - if (hasStarted) { - return true; - } else { - //TODO should try to stop this executable - return true; - } - } - - @Override public boolean hasStarted() { return this.hasStarted; } http://git-wip-us.apache.org/repos/asf/kylin/blob/d7ebaec5/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/NoopScheduler.java ---------------------------------------------------------------------- diff --git a/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/NoopScheduler.java b/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/NoopScheduler.java index 0a7eecf..2e25611 100644 --- a/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/NoopScheduler.java +++ b/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/NoopScheduler.java @@ -40,11 +40,6 @@ public class NoopScheduler implements Scheduler<AbstractExecutable> { } @Override - public boolean stop(AbstractExecutable executable) throws SchedulerException { - return false; - } - - @Override public boolean hasStarted() { return false; }
