Repository: incubator-kylin Updated Branches: refs/heads/1.x-staging 3e2ccfbe3 -> e1cd2efa8
KYLIN-752 Fix test case Project: http://git-wip-us.apache.org/repos/asf/incubator-kylin/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-kylin/commit/e1cd2efa Tree: http://git-wip-us.apache.org/repos/asf/incubator-kylin/tree/e1cd2efa Diff: http://git-wip-us.apache.org/repos/asf/incubator-kylin/diff/e1cd2efa Branch: refs/heads/1.x-staging Commit: e1cd2efa8a45b0239fe526af55b4ad3ecf5034aa Parents: 3e2ccfb Author: Li, Yang <yang...@ebay.com> Authored: Mon Nov 2 17:39:45 2015 +0800 Committer: Li, Yang <yang...@ebay.com> Committed: Mon Nov 2 17:39:45 2015 +0800 ---------------------------------------------------------------------- .../storage/hbase/ColumnValueRangeTest.java | 23 +++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/e1cd2efa/storage/src/test/java/org/apache/kylin/storage/hbase/ColumnValueRangeTest.java ---------------------------------------------------------------------- diff --git a/storage/src/test/java/org/apache/kylin/storage/hbase/ColumnValueRangeTest.java b/storage/src/test/java/org/apache/kylin/storage/hbase/ColumnValueRangeTest.java index bb100db..769b790 100644 --- a/storage/src/test/java/org/apache/kylin/storage/hbase/ColumnValueRangeTest.java +++ b/storage/src/test/java/org/apache/kylin/storage/hbase/ColumnValueRangeTest.java @@ -18,7 +18,7 @@ package org.apache.kylin.storage.hbase; -import static org.junit.Assert.assertEquals; +import static org.junit.Assert.*; import java.util.Arrays; import java.util.HashSet; @@ -44,6 +44,7 @@ public class ColumnValueRangeTest { r1.preEvaluateWithDict(dict); assertEquals(set("CN", "US"), r1.getEqualValues()); + // less than rounding { ColumnValueRange r2 = new ColumnValueRange(col, set("CN"), FilterOperatorEnum.LT); r2.preEvaluateWithDict(dict); @@ -53,14 +54,15 @@ public class ColumnValueRangeTest { ColumnValueRange r3 = new ColumnValueRange(col, set("Other"), FilterOperatorEnum.LT); r3.preEvaluateWithDict(dict); assertEquals(null, r3.getBeginValue()); - assertEquals("US", r3.getEndValue()); + assertEquals("CN", r3.getEndValue()); ColumnValueRange r4 = new ColumnValueRange(col, set("UT"), FilterOperatorEnum.LT); r4.preEvaluateWithDict(dict); assertEquals(null, r4.getBeginValue()); - assertEquals(null, r4.getEndValue()); + assertEquals("US", r4.getEndValue()); } + // greater than rounding { ColumnValueRange r2 = new ColumnValueRange(col, set("CN"), FilterOperatorEnum.GTE); r2.preEvaluateWithDict(dict); @@ -69,14 +71,25 @@ public class ColumnValueRangeTest { ColumnValueRange r3 = new ColumnValueRange(col, set("Other"), FilterOperatorEnum.GTE); r3.preEvaluateWithDict(dict); - assertEquals("CN", r3.getBeginValue()); + assertEquals("US", r3.getBeginValue()); assertEquals(null, r3.getEndValue()); ColumnValueRange r4 = new ColumnValueRange(col, set("CI"), FilterOperatorEnum.GTE); r4.preEvaluateWithDict(dict); - assertEquals(null, r4.getBeginValue()); + assertEquals("CN", r4.getBeginValue()); assertEquals(null, r4.getEndValue()); } + + // ever false check + { + ColumnValueRange r2 = new ColumnValueRange(col, set("UT"), FilterOperatorEnum.GTE); + r2.preEvaluateWithDict(dict); + assertTrue(r2.satisfyNone()); + + ColumnValueRange r3 = new ColumnValueRange(col, set("CM"), FilterOperatorEnum.LT); + r3.preEvaluateWithDict(dict); + assertTrue(r3.satisfyNone()); + } } public static Dictionary<String> mockupDictionary(TblColRef col, String... values) {