This is an automated email from the ASF dual-hosted git repository.

yao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new b02fb58  [KYUUBI #2187] Manage test failures with kyuubi spark nightly 
build - execute simple scala code *** FAILED ***
b02fb58 is described below

commit b02fb584d068cc41bb9b9dd8d5554e948953223d
Author: Nick Song <[email protected]>
AuthorDate: Sun Mar 20 23:22:34 2022 +0800

    [KYUUBI #2187] Manage test failures with kyuubi spark nightly build - 
execute simple scala code *** FAILED ***
    
    ### _Why are the changes needed?_
    
    execute simple scala code *** FAILED ***
    
scala.Predef.augmentString("\d\.\d\.\d").r.pattern.matcher(sparkVer).matches() 
was false (SparkQueryTests.scala:423)
    #2187
    
    ### _How was this patch tested?_
    - [ ] Add some test cases that check the changes thoroughly including 
negative and positive cases if possible
    
    - [ ] Add screenshots for manual tests if appropriate
    
    - [X] [Run 
test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests)
 locally before make a pull request
    
    Closes #2191 from Nick-0723/fix_sparkversion_test.
    
    Closes #2187
    
    75ab29a0 [Nick Song] fix spark version test, spark master version with 
'-SNAPSHOT'
    
    Authored-by: Nick Song <[email protected]>
    Signed-off-by: Kent Yao <[email protected]>
---
 .../src/test/scala/org/apache/kyuubi/operation/SparkQueryTests.scala    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/kyuubi-common/src/test/scala/org/apache/kyuubi/operation/SparkQueryTests.scala
 
b/kyuubi-common/src/test/scala/org/apache/kyuubi/operation/SparkQueryTests.scala
index 490332f..ac33b7c 100644
--- 
a/kyuubi-common/src/test/scala/org/apache/kyuubi/operation/SparkQueryTests.scala
+++ 
b/kyuubi-common/src/test/scala/org/apache/kyuubi/operation/SparkQueryTests.scala
@@ -420,7 +420,7 @@ trait SparkQueryTests extends HiveJDBCTestHelper {
       rs.next()
       // scala repl will return resX = YYYYY, and here we only check YYYYY
       val sparkVer = rs.getString(1).split("=")(1).trim
-      assert("\\d\\.\\d\\.\\d".r.pattern.matcher(sparkVer).matches())
+      
assert("\\d\\.\\d\\.\\d(-SNAPSHOT)?".r.pattern.matcher(sparkVer).matches())
       assert(rs.getMetaData.getColumnName(1) === "output")
     }
   }

Reply via email to