This is an automated email from the ASF dual-hosted git repository.

feiwang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new 9e40e39c39 [KYUUBI #7093] Log the metadata cleanup count
9e40e39c39 is described below

commit 9e40e39c39566c435ad92f0659c6120b9f2b8578
Author: Wang, Fei <[email protected]>
AuthorDate: Tue Jun 10 06:59:57 2025 -0700

    [KYUUBI #7093] Log the metadata cleanup count
    
    ### Why are the changes needed?
    
    To show how many metadata records cleaned up.
    ### How was this patch tested?
    
    ```
    (base) ➜  kyuubi git:(delete_metadata) grep 'Cleaned up' 
target/unit-tests.log
    01:58:17.109 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.124 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.144 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.161 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.180 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.199 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.216 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.236 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.253 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.270 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.290 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.310 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.327 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.348 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.368 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.384 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.400 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.419 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.437 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.456 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.475 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.493 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.513 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.533 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.551 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.569 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.590 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.611 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.631 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.651 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.668 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.688 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.705 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.725 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.744 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.764 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.784 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.801 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.822 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.849 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.870 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.889 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.910 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.929 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.948 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.970 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:17.994 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:18.014 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:18.032 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:18.050 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:18.069 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:18.086 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 0 records older than 1000 ms from metadata.
    01:58:18.108 ScalaTest-run-running-JDBCMetadataStoreSuite INFO 
JDBCMetadataStore: Cleaned up 1 records older than 1000 ms from metadata.
    01:58:18.162 ScalaTest-run INFO JDBCMetadataStore: Cleaned up 0 records 
older than 0 ms from k8s_engine_info.
    ```
    ### Was this patch authored or co-authored using generative AI tooling?
    
    No.
    
    Closes #7093 from turboFei/delete_metadata.
    
    Closes #7093
    
    e0cf300f8 [Wang, Fei] update
    
    Authored-by: Wang, Fei <[email protected]>
    Signed-off-by: Wang, Fei <[email protected]>
---
 .../apache/kyuubi/server/metadata/jdbc/JDBCMetadataStore.scala    | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git 
a/kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStore.scala
 
b/kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStore.scala
index 4a020ed6e4..a7226c0a1f 100644
--- 
a/kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStore.scala
+++ 
b/kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStore.scala
@@ -415,7 +415,9 @@ class JDBCMetadataStore(conf: KyuubiConf) extends 
MetadataStore with Logging {
     val minEndTime = System.currentTimeMillis() - maxAge
     val query = s"DELETE FROM $METADATA_TABLE WHERE state IN ($terminalStates) 
AND end_time < ?"
     JdbcUtils.withConnection { connection =>
-      execute(connection, query, minEndTime)
+      withUpdateCount(connection, query, minEndTime) { count =>
+        info(s"Cleaned up $count records older than $maxAge ms from 
$METADATA_TABLE.")
+      }
     }
   }
 
@@ -465,7 +467,9 @@ class JDBCMetadataStore(conf: KyuubiConf) extends 
MetadataStore with Logging {
     val minUpdateTime = System.currentTimeMillis() - maxAge
     val query = s"DELETE FROM $KUBERNETES_ENGINE_INFO_TABLE WHERE update_time 
< ?"
     JdbcUtils.withConnection { connection =>
-      execute(connection, query, minUpdateTime)
+      withUpdateCount(connection, query, minUpdateTime) { count =>
+        info(s"Cleaned up $count records older than $maxAge ms from 
$KUBERNETES_ENGINE_INFO_TABLE.")
+      }
     }
   }
 

Reply via email to