This is an automated email from the ASF dual-hosted git repository.
chengpan pushed a commit to branch branch-0.5
in repository https://gitbox.apache.org/repos/asf/kyuubi-shaded.git
The following commit(s) were added to refs/heads/branch-0.5 by this push:
new 6b340c2 [KYUUBI-SHADED #65] Replace `os-maven-plugin` with `nisse`
6b340c2 is described below
commit 6b340c2516092fc3f9f3547d119cfedbd1d5e458
Author: Cheng Pan <[email protected]>
AuthorDate: Mon Jul 21 11:46:33 2025 +0800
[KYUUBI-SHADED #65] Replace `os-maven-plugin` with `nisse`
### _Why are the changes needed?_
[Nisse](https://github.com/maveniverse/nisse) provides drop-in-replacement
for discontinued [OS Detector
plugin](https://github.com/trustin/os-maven-plugin), the former works for both
Maven 3 and 4, but the latter does not work for upcoming Maven 4.
https://maven.apache.org/docs/4.0.0-rc-3/release-notes.html
> the useful, but unmaintained,
[os-maven-plugin](https://github.com/trustin/os-maven-plugin/) extension has
been replaced with at [nisse](https://github.com/maveniverse/nisse) extension.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including
negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run
test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests)
locally before make a pull request
Closes #65 from pan3793/nisse.
079666e [Cheng Pan] Replace os-maven-plugin with nisse
Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit d9b1fed99f6706f9f390fc4d186576c5a3813225)
Signed-off-by: Cheng Pan <[email protected]>
---
.mvn/extensions.xml | 24 ++++++++++++++++++++++++
.mvn/maven.config | 1 +
pom.xml | 7 -------
3 files changed, 25 insertions(+), 7 deletions(-)
diff --git a/.mvn/extensions.xml b/.mvn/extensions.xml
new file mode 100644
index 0000000..da2aee8
--- /dev/null
+++ b/.mvn/extensions.xml
@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+<extensions>
+ <extension>
+ <groupId>eu.maveniverse.maven.nisse</groupId>
+ <artifactId>extension</artifactId>
+ <version>0.4.6</version>
+ </extension>
+</extensions>
diff --git a/.mvn/maven.config b/.mvn/maven.config
new file mode 100644
index 0000000..e61f1a9
--- /dev/null
+++ b/.mvn/maven.config
@@ -0,0 +1 @@
+-Dnisse.compat.osDetector
diff --git a/pom.xml b/pom.xml
index 8d48aa8..6b59a4e 100644
--- a/pom.xml
+++ b/pom.xml
@@ -459,13 +459,6 @@
</executions>
</plugin>
</plugins>
- <extensions>
- <extension>
- <groupId>kr.motd.maven</groupId>
- <artifactId>os-maven-plugin</artifactId>
- <version>${maven.plugin.os.version}</version>
- </extension>
- </extensions>
</build>
<profiles>
