svn commit: r803438 - in /labs/hupa/src/main/java/org/apache/hupa: client/mvp/IMAPMessagePresenter.java client/mvp/MessageSendPresenter.java shared/data/Util.java

[norman]

Author: norman
Date: Wed Aug 12 10:39:57 2009
New Revision: 803438

URL: http://svn.apache.org/viewvc?rev=803438&view=rev
Log:
Remove duplicated code

Modified:
    labs/hupa/src/main/java/org/apache/hupa/client/mvp/IMAPMessagePresenter.java
    labs/hupa/src/main/java/org/apache/hupa/client/mvp/MessageSendPresenter.java
    labs/hupa/src/main/java/org/apache/hupa/shared/data/Util.java

Modified: 
labs/hupa/src/main/java/org/apache/hupa/client/mvp/IMAPMessagePresenter.java
URL: 
http://svn.apache.org/viewvc/labs/hupa/src/main/java/org/apache/hupa/client/mvp/IMAPMessagePresenter.java?rev=803438&r1=803437&r2=803438&view=diff
==============================================================================
--- 
labs/hupa/src/main/java/org/apache/hupa/client/mvp/IMAPMessagePresenter.java 
(original)
+++ 
labs/hupa/src/main/java/org/apache/hupa/client/mvp/IMAPMessagePresenter.java 
Wed Aug 12 10:39:57 2009
@@ -92,8 +92,8 @@
 
        private void updateDisplay() {
                display.getFrom().setText(message.getHeader().getFrom());
-               
display.getCc().setText(arrayToString(message.getHeader().getCc()));
-               
display.getTo().setText(arrayToString(message.getHeader().getTo()));
+               
display.getCc().setText(Util.arrayToString(message.getHeader().getCc()));
+               
display.getTo().setText(Util.arrayToString(message.getHeader().getTo()));
                display.getSubject().setText(message.getHeader().getSubject());
                String con = message.getMessageContent().getText();
                if (message.getMessageContent().isHTML() == false) {
@@ -103,17 +103,6 @@
                
display.setAttachments(message.getMessageContent().getMessageAttachments(),user.getSessionId(),
 folder.getFullName(),message.getUid());
        }
        
-       private String arrayToString(ArrayList<String> aList) {
-               StringBuffer sb = new StringBuffer();
-               for (int i = 0; i < aList.size(); i++) {
-                       sb.append(aList.get(i));
-                       if (i < aList.size()-1) {
-                               sb.append(", ");
-                       }
-               }
-               return sb.toString();
-       }
-
        @Override
        public Place getPlace() {
                return PLACE;

Modified: 
labs/hupa/src/main/java/org/apache/hupa/client/mvp/MessageSendPresenter.java
URL: 
http://svn.apache.org/viewvc/labs/hupa/src/main/java/org/apache/hupa/client/mvp/MessageSendPresenter.java?rev=803438&r1=803437&r2=803438&view=diff
==============================================================================
--- 
labs/hupa/src/main/java/org/apache/hupa/client/mvp/MessageSendPresenter.java 
(original)
+++ 
labs/hupa/src/main/java/org/apache/hupa/client/mvp/MessageSendPresenter.java 
Wed Aug 12 10:39:57 2009
@@ -40,6 +40,7 @@
 import org.apache.hupa.shared.data.MessageContent;
 import org.apache.hupa.shared.data.MessageHeader;
 import org.apache.hupa.shared.data.User;
+import org.apache.hupa.shared.data.Util;
 import org.apache.hupa.shared.events.FolderSelectionEvent;
 import org.apache.hupa.shared.events.FolderSelectionEventHandler;
 import org.apache.hupa.shared.events.LoadMessagesEvent;
@@ -312,10 +313,10 @@
                                
display.getToText().setText(oldmessage.getHeader().getFrom());
                        } else {
                                
oldmessage.getHeader().getCc().remove(user.getName());
-                               
display.getCcText().setText(arrayToString(oldmessage.getHeader().getCc()));
+                               
display.getCcText().setText(Util.arrayToString(oldmessage.getHeader().getCc()));
                                
oldmessage.getHeader().getTo().remove(user.getName());
 
-                               
display.getToText().setText(arrayToString(oldmessage.getHeader().getTo()));
+                               
display.getToText().setText(Util.arrayToString(oldmessage.getHeader().getTo()));
 
                        }
                }else {
@@ -328,17 +329,4 @@
                bind(user,null,null,type);
        }
        
-
-       private String arrayToString(ArrayList<String> aList) {
-               StringBuffer sb = new StringBuffer();
-               for (int i = 0; i < aList.size(); i++) {
-                       sb.append(aList.get(i));
-                       if (i < aList.size()-1) {
-                               sb.append(", ");
-                       }
-               }
-               return sb.toString();
-       }
-
-       
 }

Modified: labs/hupa/src/main/java/org/apache/hupa/shared/data/Util.java
URL: 
http://svn.apache.org/viewvc/labs/hupa/src/main/java/org/apache/hupa/shared/data/Util.java?rev=803438&r1=803437&r2=803438&view=diff
==============================================================================
--- labs/hupa/src/main/java/org/apache/hupa/shared/data/Util.java (original)
+++ labs/hupa/src/main/java/org/apache/hupa/shared/data/Util.java Wed Aug 12 
10:39:57 2009
@@ -19,6 +19,8 @@
 
 package org.apache.hupa.shared.data;
 
+import java.util.ArrayList;
+
 public class Util {
        
        public final static String HTML_LT = "&lt";
@@ -45,4 +47,15 @@
                }
                return string;
        }
+       
+       public static String arrayToString(ArrayList<String> aList) {
+               StringBuffer sb = new StringBuffer();
+               for (int i = 0; i < aList.size(); i++) {
+                       sb.append(aList.get(i));
+                       if (i < aList.size()-1) {
+                               sb.append(", ");
+                       }
+               }
+               return sb.toString();
+       }
 }



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@labs.apache.org
For additional commands, e-mail: commits-h...@labs.apache.org