Author: norman
Date: Tue Aug 18 19:59:44 2009
New Revision: 805557

URL: http://svn.apache.org/viewvc?rev=805557&view=rev
Log:
Some cleanup

Modified:
    labs/hupa/src/main/java/org/apache/hupa/client/widgets/EditableTree.java
    labs/hupa/src/main/java/org/apache/hupa/client/widgets/EditableTreeItem.java
    labs/hupa/src/main/java/org/apache/hupa/client/widgets/IMAPTreeItem.java

Modified: 
labs/hupa/src/main/java/org/apache/hupa/client/widgets/EditableTree.java
URL: 
http://svn.apache.org/viewvc/labs/hupa/src/main/java/org/apache/hupa/client/widgets/EditableTree.java?rev=805557&r1=805556&r2=805557&view=diff
==============================================================================
--- labs/hupa/src/main/java/org/apache/hupa/client/widgets/EditableTree.java 
(original)
+++ labs/hupa/src/main/java/org/apache/hupa/client/widgets/EditableTree.java 
Tue Aug 18 19:59:44 2009
@@ -25,6 +25,11 @@
 import com.google.gwt.user.client.ui.TreeImages;
 import com.google.gwt.user.client.ui.TreeItem;
 
+/**
+ * Tree which can holds EditableTreeItem instances
+ * 
+ *
+ */
 public class EditableTree extends Tree {
        public EditableTree(TreeImages images, boolean leaf) {
                super(images, leaf);

Modified: 
labs/hupa/src/main/java/org/apache/hupa/client/widgets/EditableTreeItem.java
URL: 
http://svn.apache.org/viewvc/labs/hupa/src/main/java/org/apache/hupa/client/widgets/EditableTreeItem.java?rev=805557&r1=805556&r2=805557&view=diff
==============================================================================
--- 
labs/hupa/src/main/java/org/apache/hupa/client/widgets/EditableTreeItem.java 
(original)
+++ 
labs/hupa/src/main/java/org/apache/hupa/client/widgets/EditableTreeItem.java 
Tue Aug 18 19:59:44 2009
@@ -32,10 +32,15 @@
 import com.google.gwt.user.client.ui.TreeItem;
 import com.google.gwt.user.client.ui.Widget;
 
+/**
+ * TreeItem which supports editing
+ * 
+ *
+ */
 public class EditableTreeItem extends TreeItem implements 
HasEditable,HasEditHandlers{
        protected TextBox editBox = new TextBox();
        protected String oldValue;
-       private Widget normalItem = new Label();
+       protected Widget normalItem = new Label();
        protected HandlerManager manager = new HandlerManager(this);
        public EditableTreeItem() {
                editBox.setWidth("100px");
@@ -44,6 +49,7 @@
                        public void onKeyDown(KeyDownEvent event) {
                                int code = event.getNativeKeyCode();
                                switch (code) {
+                               // handle ENTER and ESCAPE keys
                                case KeyCodes.KEY_ENTER:
                                        stopEdit();
                                        break;
@@ -113,6 +119,11 @@
                manager.fireEvent(new 
EditEvent(EditEvent.EventType.Start,oldValue,null));
        }
        
+       /**
+        * Show the editbox filled with the given value 
+        * 
+        * @param value
+        */
        protected void showEditBox(String value) {
                editBox.setText(value);
                editBox.setCursorPos(value.length());
@@ -130,7 +141,12 @@
                manager.fireEvent(new 
EditEvent(EditEvent.EventType.Stop,oldValue,editBox.getText()));
        }
 
-       public void showItem(String text) {
+       /**
+        * Show the "normal" item with the given text
+        * 
+        * @param text
+        */
+       protected void showItem(String text) {
                ((HasText)normalItem).setText(text);
                setWidget(normalItem);
        }
@@ -140,6 +156,10 @@
                return ((HasText)normalItem).getText();
        }
        
+       /*
+        * (non-Javadoc)
+        * @see 
org.apache.hupa.client.widgets.HasEditHandlers#addEditHandler(org.apache.hupa.client.widgets.EditHandler)
+        */
        public HandlerRegistration addEditHandler(EditHandler handler) {
                return manager.addHandler(EditEvent.TYPE, handler);
        }

Modified: 
labs/hupa/src/main/java/org/apache/hupa/client/widgets/IMAPTreeItem.java
URL: 
http://svn.apache.org/viewvc/labs/hupa/src/main/java/org/apache/hupa/client/widgets/IMAPTreeItem.java?rev=805557&r1=805556&r2=805557&view=diff
==============================================================================
--- labs/hupa/src/main/java/org/apache/hupa/client/widgets/IMAPTreeItem.java 
(original)
+++ labs/hupa/src/main/java/org/apache/hupa/client/widgets/IMAPTreeItem.java 
Tue Aug 18 19:59:44 2009
@@ -30,10 +30,7 @@
                setFolderText(folder);  
        }
 
-       /*
-        * (non-Javadoc)
-        * @see com.google.gwt.user.client.ui.TreeItem#setSelected(boolean)
-        */
+       @Override
        public void setSelected(boolean selected) {
                super.setSelected(selected);
                if (isSelected()) {
@@ -93,14 +90,17 @@
                setText(getFolderName(folder));
        }
        
+       /**
+        * Return the folder name to display in the TreeItem for the given 
IMAPFolder
+        * 
+        * @param folder
+        * @return name
+        */
        private String getFolderName(IMAPFolder folder) {
                return folder.getName() + " 
("+folder.getUnseeMessageCount()+")";
        }
        
-       /*
-        * (non-Javadoc)
-        * @see 
com.google.gwt.user.client.ui.TreeItem#setUserObject(java.lang.Object)
-        */
+       @Override
        public void setUserObject(Object obj) {
                if ((obj instanceof IMAPFolder) == false) {
                        throw new IllegalArgumentException("UserObject needs to 
be an instance of IMAPFolder");
@@ -119,6 +119,7 @@
                manager.fireEvent(new 
EditEvent(EditEvent.EventType.Start,oldFullName,null));
        }
        
+       @Override
        public void cancelEdit() {
                IMAPFolder folder = ((IMAPFolder) getUserObject());
                folder.setFullName(oldFullName);
@@ -128,6 +129,7 @@
 
        }
        
+       @Override
        public void stopEdit() {
                String newFolderName = editBox.getText();
                String newFullFolderName = oldFullName.substring(0, 
oldFullName.length() - oldName.length())  + newFolderName; 



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to