Author: simoneg
Date: Tue Sep 8 16:21:25 2009
New Revision: 812576
URL: http://svn.apache.org/viewvc?rev=812576&view=rev
Log:
LABS-441 : using @MagReadOnly on a public setId
Modified:
labs/magma/trunk/database-jpa/src/main/java/org/apache/magma/database/openjpa/InstallIdByDefault.aj
labs/magma/trunk/database-jpa/src/test/java/org/apache/magma/database/openjpa/TestJPAPersistedInjection.java
Modified:
labs/magma/trunk/database-jpa/src/main/java/org/apache/magma/database/openjpa/InstallIdByDefault.aj
URL:
http://svn.apache.org/viewvc/labs/magma/trunk/database-jpa/src/main/java/org/apache/magma/database/openjpa/InstallIdByDefault.aj?rev=812576&r1=812575&r2=812576&view=diff
==============================================================================
---
labs/magma/trunk/database-jpa/src/main/java/org/apache/magma/database/openjpa/InstallIdByDefault.aj
(original)
+++
labs/magma/trunk/database-jpa/src/main/java/org/apache/magma/database/openjpa/InstallIdByDefault.aj
Tue Sep 8 16:21:25 2009
@@ -22,6 +22,8 @@
import javax.persistence.Id;
import javax.persistence.EmbeddedId;
+import org.apache.magma.beans.MagReadOnly;
+
/**
* Adds by default an id to those entities that does not have it.
*
@@ -59,7 +61,8 @@
* Setter for the default id.
* @param newId The entity id.
*/
- void WithDefaultId.setId(long newId) {
+ @MagReadOnly
+ public void WithDefaultId.setId(long newId) {
id = newId;
}
Modified:
labs/magma/trunk/database-jpa/src/test/java/org/apache/magma/database/openjpa/TestJPAPersistedInjection.java
URL:
http://svn.apache.org/viewvc/labs/magma/trunk/database-jpa/src/test/java/org/apache/magma/database/openjpa/TestJPAPersistedInjection.java?rev=812576&r1=812575&r2=812576&view=diff
==============================================================================
---
labs/magma/trunk/database-jpa/src/test/java/org/apache/magma/database/openjpa/TestJPAPersistedInjection.java
(original)
+++
labs/magma/trunk/database-jpa/src/test/java/org/apache/magma/database/openjpa/TestJPAPersistedInjection.java
Tue Sep 8 16:21:25 2009
@@ -17,6 +17,9 @@
package org.apache.magma.database.openjpa;
import static org.junit.Assert.*;
+import static org.hamcrest.CoreMatchers.*;
+
+import java.lang.reflect.Method;
import org.apache.magma.database.DatabasePersisted;
import org.apache.magma.database.openjpa.InstallIdByDefault.WithDefaultId;
@@ -24,6 +27,7 @@
import org.apache.magma.database.openjpa.stuff.EmptyFakeBean;
import org.apache.magma.database.openjpa.stuff.FakeBean;
import org.apache.magma.database.openjpa.stuff.FakeBeanPropertyAccess;
+import org.apache.magma.database.openjpa.stuff.FakeSubBean;
import org.apache.magma.database.openjpa.stuff.NoIdFakeBean;
import org.apache.magma.database.openjpa.stuff.NoVersionFakeBean;
@@ -60,5 +64,19 @@
assertTrue("No default version" + b.getClass(), b instanceof
WithDefaultVersion);
}
+ /*
+ * TODO enable this when AspectJ bug is closed
+ @Test
+ public void noDoubles() throws Exception {
+ Method[] methods = FakeSubBean.class.getMethods();
+ for (Method method : methods) {
+ System.out.println(method.getName() + " : " +
method.getDeclaringClass().getName());
+ if
(method.getDeclaringClass().equals(FakeSubBean.class)) {
+ assertThat(method.getName(),
not(equalTo("getVersion")));
+ //assertThat(method.getName(),
not(equalTo("getId")));
+ }
+ }
+ }
+ */
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
