[
https://issues.apache.org/jira/browse/LIBCLOUD-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767470#comment-13767470
]
Tomaz Muraus commented on LIBCLOUD-397:
---------------------------------------
Thanks, I have a couple of comments:
1. Please put the code in an external file (docs/example/compute) and include
it in the documentation. This way way it's easier to keep it up to date, we can
lint it, test it, etc.
2. There are a couple of pep8 issues in the code
3. "for" loop could be better rewriting using a list comprehension - location =
[l for l in driver.list_locations() if l.id == '82'][0]. Same goes for sizes.
4.Relying on ordering (size=conn.list_sizes()[2]) is usually a bad idea since
it can change, etc. You should do the same thing you do for a location and
select a size based on the id or name.
> Add an IBM SCE Windows node example to documentation
> ----------------------------------------------------
>
> Key: LIBCLOUD-397
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-397
> Project: Libcloud
> Issue Type: Improvement
> Components: Documentation
> Affects Versions: 0.13.1
> Reporter: Sengor Kusturica
> Priority: Minor
> Labels: documentation, patch
> Attachments: LIBCLOUD-397.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> This is a followup to the mailing list discussion @
> http://mail-archives.apache.org/mod_mbox/libcloud-users/201304.mbox/%3ccajmhem+v_wmxxwlobn-jeclpfo6c7kswxtfmnze+tmnzihw...@mail.gmail.com%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
