[
https://issues.apache.org/jira/browse/LIBCLOUD-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13786209#comment-13786209
]
Tomaz Muraus commented on LIBCLOUD-405:
---------------------------------------
Yeah, this seems reasonable for me.
Feel free to make this change and attach the patch here.
> GoGridNodeDriver should inherit from NodeDriver first, and not have a defined
> __init__
> --------------------------------------------------------------------------------------
>
> Key: LIBCLOUD-405
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-405
> Project: Libcloud
> Issue Type: Improvement
> Components: Compute
> Affects Versions: 0.13.2
> Reporter: Robert Keizer
>
> Currently compute.drivers.gogrid.GoGridNodeDriver inherits from
> BaseGoGridDriver and NodeDriver, in that order. This results in __init__
> needing to be defined in the GoGridNodeDriver itself.
> This in effect hides the argument specification of GoGridNodeDriver.__init__.
> While a docstring does exist mentioning the inheritance, other systems such
> as inspect.getargspec fail to retrieve anything useful.
> I propose that the order of inheritance be reversed. This would allow for the
> removal of __init__.
> After a cursory look at the contents of BaseGoGridDriver, it does not look to
> define anything that also exists in NodeDriver or parent classes.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
